Jira (FACT-2954) Improve fact blocking mechanism in Facter 4

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2954 Improve fact blocking mechanism in Facter 4 Change By: Josh Cooper Security: Internal Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-2954

Re: Improve fact blocking mechanism in Facter 4 Although FACT-2954 was filed first, FACT-3161 has a better description and steps to reproduce, so closing this one as a dup.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-2954

Re: Improve fact blocking mechanism in Facter 4

FACT-3161 is actually a separate (but related) issue, so reopening this ticket.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2954

Improve fact blocking mechanism in Facter 4

Change By: Josh Cooper Story Points: 5 3

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2954 Improve fact blocking mechanism in Facter 4

Change By: Josh Cooper Priority: Normal High

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2954 Improve fact blocking mechanism in Facter 4

Change By: Josh Cooper Epic Link: FACT PUP - 3051 11659

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2954 Improve fact blocking mechanism in Facter 4 Change By: Josh Cooper

Facter's block list logic is O^2 (comparing every fact against every blocked fact) [https://github.com/puppetlabs/facter/blob/83aa51aa822aea7cf5ac6762039a4529f73a2a82/lib/facter/framework/core/fact_loaders/fact_loader.rb#L100-L117.] Also it creates a regexp literal inside of the loop, which are [not frozen until ruby 3|[https://github.com/ruby/ruby/commit/98ef38ada43338c073f50a0093196f0356284625]] So we're doing a bunch of unnecessary allocations.

Add Comment

[Josh Cooper (Jira)]

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2954 Improve fact blocking mechanism in Facter 4 Change By: Josh Cooper

Facter's block list logic is O^2 (comparing every fact against every blocked fact) [https://github.com/puppetlabs/facter/blob/83aa51aa822aea7cf5ac6762039a4529f73a2a82/lib/facter/framework/core/fact_loaders/fact_loader.rb#L100-L117.]

Also it creates a an interpolated regexp literal inside of the loop , which are [not frozen until ruby 3|https://github.com/ruby/ruby/commit/98ef38ada43338c073f50a0093196f0356284625] (multiple times for the same blocked fact) So we're doing a bunch of unnecessary allocations.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2954 Improve fact blocking mechanism in Facter 4

Change By: Josh Cooper Priority: High Normal

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Unassigned

Facter / FACT-2954 Improve fact blocking mechanism in Facter 4

Change By: Josh Cooper Assignee: Luchian Nemes

Add Comment