Jira (PUP-10227) Close the http connection prior to sleeping retry-after seconds

[Josh Cooper (JIRA)]

Josh Cooper created an issue

Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds Issue Type: Bug Assignee: Unassigned Created: 2020/01/08 1:56 PM Priority: Normal Reporter: Josh Cooper To prevent thundering herds, puppetserver may return Retry-After and ask the agent to sleep. Until recently the agent would keep the connection open, until timeout occurs. To reduce resource usage on puppetserver, we should close the connection immediately. The latest puppetserver version will return Connection: close, but agents may talk to older puppetservers versions which would benefit from this. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds

Change By: Josh Cooper Sprint: Coremunity Grooming

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds

Change By: Josh Cooper Fix Version/s: PUP 6.y Fix Version/s: PUP 6.4.z Fix Version/s: PUP 5.5.z

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10227

Re: Close the http connection prior to sleeping retry-after seconds Also need to make sure that the pool doesn't cache the closed connection.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10227

Re: Close the http connection prior to sleeping retry-after seconds

Grooming Notes: 1. Target 5.5.x 2. Need to call Net::HTTP#finish in lib/puppet/network/http/connection.rb and lib/puppet/http/client.rb. The latter only exists in master 3. Don't add a closed connection back to the pool in lib/puppet/network/http/pool.rb. Should be able to call Net::HTTP#active? which is an alias for started?.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10227

Close the http connection prior to sleeping retry-after seconds

Change By: Josh Cooper Sprint: Coremunity Grooming Hopper

Add Comment

[Melissa Stone (JIRA)]

Melissa Stone assigned an issue to Melissa Stone

Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds

Change By: Melissa Stone Assignee: Melissa Stone

Add Comment

[Melissa Stone (JIRA)]

Melissa Stone updated an issue

Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds

Change By: Melissa Stone Sprint: Coremunity Hopper Platform Core KANBAN

Add Comment

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen commented on PUP-10227

Re: Close the http connection prior to sleeping retry-after seconds Sorry, missed this one in the sea of mail. Yes, this is a great change. Also, closing on the agent side seems like the best behavior going forward as the Connection: header was removed from HTTP/2.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10227

Re: Close the http connection prior to sleeping retry-after seconds

Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/58efa4370a0177baac9f0e6395fdc656ee7a0c6a

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10227

Re: Close the http connection prior to sleeping retry-after seconds

Melissa Stone Could you add release notes?

Add Comment

[Luchian Nemes (JIRA)]

Luchian Nemes updated an issue

Puppet / PUP-10227

Close the http connection prior to sleeping retry-after seconds

Change By: Luchian Nemes Fix Version/s: PUP 6.y Fix Version/s: PUP 6.13.0

Add Comment

[Melissa Stone (JIRA)]

Melissa Stone updated an issue

Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds

Change By: Melissa Stone Release Notes Summary: When puppetserver returns a 429 or 503 to an agent when the agent tries to make an http request, the agent run will sleep and then retry the connection after. Previously, the agent kept the http connection open during the sleep. We now close the connection prior to the sleep to reduce the resource load on the puppetserver. Release Notes: Enhancement

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-10227

Re: Close the http connection prior to sleeping retry-after seconds Passed CI in 6e66cdb78e.

Add Comment

[Kate Medred (JIRA)]

Kate Medred updated an issue

Puppet / PUP-10227

Close the http connection prior to sleeping retry-after seconds

Change By: Kate Medred Labels: resolved-issue-added

Add Comment