Jira (PDB-3630) Configurable facts blacklist

9 views
Skip to first unread message

Russell Mull (JIRA)

unread,
Jul 26, 2017, 2:21:03 PM7/26/17
to puppe...@googlegroups.com
Russell Mull created an issue
 
PuppetDB / New Feature PDB-3630
Configurable facts blacklist
Issue Type: New Feature New Feature
Assignee: Unassigned
Created: 2017/07/26 11:20 AM
Priority: Normal Normal
Reporter: Russell Mull

Add a place in the puppetdb config file to put a set of facts that are blacklisted on ingestion. This will provide an escape hatch for sites that are dealing with poorly behaving facts (large, very dynamic facts) whose value they don't actually care about but which are knocking over the fact storage subsystem.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Russell Mull (JIRA)

unread,
Jul 26, 2017, 2:22:03 PM7/26/17
to puppe...@googlegroups.com
Russell Mull updated an issue
Change By: Russell Mull
Sprint: Data Platform Next Sprint

Wyatt Alt (JIRA)

unread,
Jul 26, 2017, 2:26:02 PM7/26/17
to puppe...@googlegroups.com
Wyatt Alt commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

a blacklist went into facter a while ago to address the same issue this addresses. If there's functionality gaps it'd be worth discussing that with the facter team before putting another blacklist here – having two seems confusing to support.

Russell Mull (JIRA)

unread,
Jul 26, 2017, 4:48:01 PM7/26/17
to puppe...@googlegroups.com
Russell Mull commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

Maggie Dreyer iirc you worked on the facter blacklist in some way; but I also seem to remember it having some kind of limitations. do you think it would be worth having such a mechanism in PDB, or would it be actively bad?

Maggie Dreyer (JIRA)

unread,
Jul 26, 2017, 4:52:02 PM7/26/17
to puppe...@googlegroups.com
Maggie Dreyer commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

I would be more in favor of extending the Facter blocking to address this, or maybe using caching, depending on the use case. Right now, only a small number of facts can be blocked, but we can easily extend this list. We limited it because we didn't want to enable blocking of facts that lots of other facts rely on. So instead we picked a couple known to be problematic, namely "EC2" and "filesystem" facts. Are there other specific cases you'd like to be able to block?

Wyatt Alt (JIRA)

unread,
Jul 26, 2017, 4:58:02 PM7/26/17
to puppe...@googlegroups.com
Wyatt Alt commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

Ideally the blacklist could support custom facts

Maggie Dreyer (JIRA)

unread,
Jul 26, 2017, 5:03:04 PM7/26/17
to puppe...@googlegroups.com
Maggie Dreyer commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

Ah yeah, there's a ticket for that: https://tickets.puppetlabs.com/browse/FACT-1575. Just hasn't been prioritized, but we might be able to move on it if there's demand.

Russell Mull (JIRA)

unread,
Jul 26, 2017, 5:04:04 PM7/26/17
to puppe...@googlegroups.com
Russell Mull commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

There's kind of demand; it's a facility we see being useful to work around problems that we just aren't going to be able to solve in PuppetDB any time soon.

Jeff Yarnell (JIRA)

unread,
Sep 20, 2017, 7:15:09 PM9/20/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Sprint: Bad Sprint

Jeff Yarnell (JIRA)

unread,
Sep 20, 2017, 7:15:13 PM9/20/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Sprint: Hopper

Nick Walker (JIRA)

unread,
Oct 10, 2017, 6:20:02 PM10/10/17
to puppe...@googlegroups.com
Nick Walker commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

Reopening this issue, I think we should prioritize it in the near-term. We're continuing to see customers with large facts run into performance issues and often they do not want to blacklist the fact because they use it in puppet code, however, they don't ever view it in the PE console or via PuppetDB in anyway.

Having a fact blacklist for PuppetDB is not duplicating functionality with the facter blacklist since blocking things out of PuppetDB effectively has no effect on puppet itself where as blocking facts from facter does affect puppet. The facter blacklist as discussed above requires block groups of facts which PuppetDB should allow blocking any fact by name. There are differences and implementing a PuppetDB fact blacklist is worthwhile.

Charlie Sharpsteen (JIRA)

unread,
Oct 10, 2017, 6:26:02 PM10/10/17
to puppe...@googlegroups.com
Charlie Sharpsteen commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

+1 to what Nick said above.

Brett Gray (JIRA)

unread,
Oct 11, 2017, 9:55:02 AM10/11/17
to puppe...@googlegroups.com
Brett Gray commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

+1 in support of reopening

Jeff Yarnell (JIRA)

unread,
Oct 11, 2017, 4:46:02 PM10/11/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Sprint: Hopper/Triage Data Platform 2017-10-18

Jeff Yarnell (JIRA)

unread,
Oct 11, 2017, 5:34:03 PM10/11/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Story Points: 1
Team: Data Platform

Zachary Kent (JIRA)

unread,
Oct 16, 2017, 1:15:04 PM10/16/17
to puppe...@googlegroups.com
Zachary Kent assigned an issue to Zachary Kent
Change By: Zachary Kent
Assignee: Zachary Kent

Jeff Yarnell (JIRA)

unread,
Oct 18, 2017, 5:38:06 PM10/18/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Sprint: Data Platform 2017-10-18 , Data Platform 2017-11-01

Russell Mull (JIRA)

unread,
Oct 19, 2017, 6:29:03 PM10/19/17
to puppe...@googlegroups.com
Russell Mull updated an issue
Change By: Russell Mull
Fix Version/s: PDB 5.1.2
Fix Version/s: PDB 4.4.2
Fix Version/s: PDB 4.2.3.6

Kenn Hussey (JIRA)

unread,
Oct 23, 2017, 1:31:04 PM10/23/17
to puppe...@googlegroups.com
Kenn Hussey commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

Zachary Kent please add release notes for this issue, if applicable. Thanks!

Zachary Kent (JIRA)

unread,
Oct 24, 2017, 3:21:03 PM10/24/17
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Release Notes: New Feature

Zachary Kent (JIRA)

unread,
Oct 24, 2017, 3:28:03 PM10/24/17
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Release Notes Summary: Added a facts blacklist feature to the PDB config file that allows users to specify a list of facts that will be ignored during ingestion. 

Zachary Kent (JIRA)

unread,
Oct 24, 2017, 7:35:03 PM10/24/17
to puppe...@googlegroups.com
Zachary Kent assigned an issue to Zachary Kent
Change By: Zachary Kent
Assignee: Zachary Kent

Nick Walker (JIRA)

unread,
Oct 25, 2017, 2:16:06 PM10/25/17
to puppe...@googlegroups.com
Nick Walker commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

Zachary Kent Russell Mull What is the behavior of PuppetDB when a fact is already being stored and then is added to the blacklist?

Will that fact be deleted from the database or will it stick around and just no longer receive updates?

Russell Mull (JIRA)

unread,
Oct 25, 2017, 2:49:03 PM10/25/17
to puppe...@googlegroups.com
Russell Mull commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

It should get flushed the next time a factset comes in for that node.

Zachary Kent (JIRA)

unread,
Oct 26, 2017, 6:35:05 PM10/26/17
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Fix Version/s: PDB 5.1.2
Fix Version/s: PDB 5.1.3

Russell Mull (JIRA)

unread,
Nov 7, 2017, 12:19:04 PM11/7/17
to puppe...@googlegroups.com
Russell Mull updated an issue
Change By: Russell Mull
Fix Version/s: PDB 4.2.3.6
Fix Version/s: 4.2.3.7
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Russell Mull (JIRA)

unread,
Nov 7, 2017, 12:42:03 PM11/7/17
to puppe...@googlegroups.com
Russell Mull updated an issue
Change By: Russell Mull
Fix Version/s: PDB 4.2.3.7
Fix Version/s: 4.2.3.8

Susan McNerney (JIRA)

unread,
Nov 7, 2017, 1:23:59 PM11/7/17
to puppe...@googlegroups.com
Susan McNerney commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

We will need to defer this to the next LTS z, which will be in Jan/Feb. (2016.4.10), due to lack of time to resolve getting it into 2016.4.9 before our launch window.

Russell Mull (JIRA)

unread,
Nov 8, 2017, 4:32:05 PM11/8/17
to puppe...@googlegroups.com
Russell Mull updated an issue
Change By: Russell Mull
Fix Version/s: PDB 4.4.2
Fix Version/s: 4.4.3

Russell Mull (JIRA)

unread,
Nov 8, 2017, 4:35:03 PM11/8/17
to puppe...@googlegroups.com
Russell Mull commented on New Feature PDB-3630
 
Re: Configurable facts blacklist

Updated fixversion to 4.4.3, sorry about the mistake

Claudia Petty (Jira)

unread,
Jun 21, 2023, 10:59:37 AM6/21/23
to puppe...@googlegroups.com
Claudia Petty updated an issue
Change By: Claudia Petty
Labels: new-feature
This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages