Jira (PUP-10109) Don't assume redhat is only FIPS platform

15 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Oct 23, 2019, 2:21:03 PM10/23/19
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-10109
Don't assume redhat is only FIPS platform
Issue Type: Task Task
Assignee: Unassigned
Created: 2019/10/23 11:20 AM
Priority: Normal Normal
Reporter: Josh Cooper

Puppet changes the default values for some settings like Puppet[:digest_algorithm] when fips is enabled. Puppet used to rely on the fips_enabled fact, but that caused problems when puppetserver attempts to load puppet code. See PUP-8356. So we changed puppet to reimplement what facter does to detect fips mode, however, that logic (checking for /proc/sys/crypto/fips_enabled) doesn't work on Windows.

As a result the following tests fail on windows fips:

$ git checkout 254e7776c4b8c505f6d388ef7978dee1fc7b9db3
$ cd acceptance
$ bundle update
$ bundle exec rake ci:test:aio BEAKER_HOSTS=redhat7-64m-windowsfips2012r2-64a SHA=6c226109bc3298552ac86944c7412362b9731f87 SERVER_VRESION=6.7.2.SNAPSHOT.2019.10.14T2201 TESTS=tests/parser_functions/calling_all_functions.rb,tests/puppet_apply_a_file_should_create_a_file_and_report_the_md5.rb,tests/resource/file/content_attribute.rb,tests/ticket_6541_invalid_filebucket_files.rb,tests/ticket_1334_clientbucket_corrupted.rb OPTIONS='--preserve-hosts=always'

We could update Puppet::Util::Platform.fips? to take Windows into account? Try to figure out how to resolve the puppetserver issue so puppet can use facter to resolve fips mode?

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Gheorghe Popescu (JIRA)

unread,
Oct 24, 2019, 6:48:02 AM10/24/19
to puppe...@googlegroups.com

Gheorghe Popescu (JIRA)

unread,
Oct 24, 2019, 6:49:02 AM10/24/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Sprint: NW - 2019-10-30

Gheorghe Popescu (JIRA)

unread,
Oct 24, 2019, 6:49:02 AM10/24/19
to puppe...@googlegroups.com

Gheorghe Popescu (JIRA)

unread,
Oct 24, 2019, 9:51:03 AM10/24/19
to puppe...@googlegroups.com
Gheorghe Popescu commented on Task PUP-10109
 
Re: Don't assume redhat is only FIPS platform

I opened: https://github.com/puppetlabs/puppet/pull/7789 to unblock the CI.
We can create a new ticket to investigate how we can resolve the puppetserver issues to be able to rely on facts.
Josh Cooper Mihai Buzgau

Josh Cooper (JIRA)

unread,
Oct 24, 2019, 12:43:02 PM10/24/19
to puppe...@googlegroups.com

Ciprian Badescu (JIRA)

unread,
Nov 14, 2019, 10:07:05 AM11/14/19
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
 
Change By: Ciprian Badescu
Fix Version/s: PUP 6.11.0
Reply all
Reply to author
Forward
0 new messages