Jira (FACT-2399) Structure Utils files in an organized way

15 views
Skip to first unread message

Gheorghe Popescu (JIRA)

unread,
Feb 25, 2020, 9:32:03 AM2/25/20
to puppe...@googlegroups.com
Gheorghe Popescu created an issue
 
Facter / Task FACT-2399
Structure Utils files in an organized way
Issue Type: Task Task
Assignee: Unassigned
Created: 2020/02/25 6:31 AM
Priority: Normal Normal
Reporter: Gheorghe Popescu

Utils are defined in multiple places and not namespaced(platfrom specific) which create confusion.

For example:

  • lib/resolvers/aix/utils/odm_qeury.rb -> Facter::ODMQuery
  • lib/resolvers/aix/windows
  • other util/utils folders
      

 Could be structured as: facter/utils/formatter, facter/utils/aix, facter/utils/windows
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Bogdan Irimie (Jira)

unread,
Nov 4, 2020, 9:39:02 AM11/4/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: PR - Triage
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Bogdan Irimie (Jira)

unread,
Nov 4, 2020, 9:43:03 AM11/4/20
to puppe...@googlegroups.com
Bogdan Irimie commented on Task FACT-2399
 
Re: Structure Utils files in an organized way

The Util modules in the Resolvers folder should have the following namespace:

module Facter
module Resolvers
module Utils
module UtilModule

Bogdan Irimie (Jira)

unread,
Nov 5, 2020, 3:06:02 AM11/5/20
to puppe...@googlegroups.com

The parsing of ODMQuery execute should be moved from resolvers to ODMQuery

          result = odmquery.execute
 
 
 
          return unless result
 
 
 
          result.each_line do |line|
 
            if line.include?('value')
 
              @fact_list[:architecture] = line.split('=')[1].strip.delete('\"')
 
              break
 
            end
 
          end

Bogdan Irimie (Jira)

unread,
Nov 5, 2020, 3:08:02 AM11/5/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: PR ghost - Triage 11.11

Bogdan Irimie (Jira)

unread,
Nov 5, 2020, 3:08:03 AM11/5/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Story Points: 2

Bogdan Irimie (Jira)

unread,
Nov 18, 2020, 8:50:02 AM11/18/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-11.11 , ready for triage 2

Florin Dragos (Jira)

unread,
Nov 18, 2020, 11:12:04 AM11/18/20
to puppe...@googlegroups.com
Florin Dragos assigned an issue to Florin Dragos
Change By: Florin Dragos
Assignee: Florin Dragos

Bogdan Irimie (Jira)

unread,
Nov 25, 2020, 9:04:05 AM11/25/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-11.11, ghost 25.11 , ready for triage 2

Mihai Buzgau (Jira)

unread,
Dec 9, 2020, 7:21:03 AM12/9/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: FACT 4.0.47
Reply all
Reply to author
Forward
0 new messages