Jira (PUP-9209) Don't support the home property on Windows users

Enis Inan (JIRA)

unread,

Oct 4, 2018, 5:50:04 PM10/4/18

to puppe...@googlegroups.com

Enis Inan created an issue

Puppet /

PUP-9209

Don't support the home property on Windows users

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2018/10/04 2:49 PM
Priority:	Normal
Reporter:	Enis Inan

The current Windows user provider supports the home property of the User resource, which delegates to getting/setting the HomeDirectory property of the IADS User with WinNT as the provider (here's the code).

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Enis Inan (JIRA)

unread,

Oct 4, 2018, 5:50:05 PM10/4/18

to puppe...@googlegroups.com

Enis Inan updated an issue

Puppet /

PUP-9209

Don't support the home property on Windows users

Change By:	Enis Inan
Fix Version/s:	PUP 7.0.0

Add Comment

Enis Inan (JIRA)

unread,

Oct 4, 2018, 5:52:03 PM10/4/18

to puppe...@googlegroups.com

Enis Inan updated an issue

Puppet /

PUP-9209

Don't support the home property on Windows users

Change By:	Enis Inan

The current Windows user provider supports the home property of the User resource, which delegates to getting/setting the HomeDirectory property of the IADS User with WinNT as the provider ([here's|https://github.com/puppetlabs/puppet/blob/6.0.0/lib/puppet/provider/user/windows_adsi.rb#L111-L117] the code). The home property does not make sense on Windows, because the user's profile (which is the home's directory) will always be in C:\Users -- we already create/delete the user profile via. the managehome property. Furthermore, the HomeDirectory property does not seem to do anything useful in terms of implementing the home property of the User resource.

Add Comment

Enis Inan (JIRA)

unread,

Oct 4, 2018, 5:54:03 PM10/4/18

to puppe...@googlegroups.com

Enis Inan updated an issue

Puppet /

PUP-9209

Don't support the home property on Windows users

Change By:	Enis Inan

The current Windows user provider supports the home property of the User resource, which delegates to getting/setting the HomeDirectory property of the IADS User with WinNT as the provider ([here's|https://github.com/puppetlabs/puppet/blob/6.0.0/lib/puppet/provider/user/windows_adsi.rb#L111-L117] the code). The home property does not make sense on Windows, because the user's profile (which is the home 's directory) will always be in C:\Users -- we already create/delete the user profile via. the managehome property. Furthermore, the HomeDirectory property does not seem to do anything useful from Puppet's perspective.

Thus, we should stop supporting the 'home' property for our Windows user provider. There are several paths we can take here:
* Fail fast in terms of implementing the property validation code (i.e. the validate block)
* Associate a feature with the home property of (e.g. sets_home_directory) and apply that feature to the current User resource providers that support the home property .

and more.