Jira (FACT-3078) custom-dir is silently skipped if it is not absolute path

[Ciprian Badescu (Jira)]

Ciprian Badescu created an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path Issue Type: Task Assignee: Unassigned Created: 2021/10/06 3:45 AM Priority: Normal Reporter: Ciprian Badescu When custom-dir is not an absolute path, Facter 4 logs a debug message and ignores the directory (behavior inherited from Facter 2) while Facter 3 accepts relative paths as custom-dir.   I suppose  Facter 4 behavior should match Facter 3 behavior. Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Ciprian Badescu

When custom-dir is not an absolute path, Facter 4 logs a debug message and ignores the directory (behavior inherited from Facter 2) while Facter 3 accepts relative paths as custom-dir.   I suppose  Facter 4 behavior should match Facter 3 behavior.

{code:java} $ facter --custom-dir non-existing --debug 2>&1  | grep non-existing [2021-10-06 13:46:20.375087 ] INFO Facter - executed with command line: --custom-dir non-existing --debug [2021-10-06 13:46:20.376933 ] DEBUG LegacyFacter::Util::Loader - Excluding non-existing from search path. Fact file paths must be an absolute directory {code}

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Ciprian Badescu Labels: needs_repro

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Ciprian Badescu Team: Night's Watch

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu commented on FACT-3078

Re: custom-dir is silently skipped if it is not absolute path should check if external-dir behaves the same way

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-3078

custom-dir is silently skipped if it is not absolute path

Change By: Ciprian Badescu Labels: needs_repro

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu commented on FACT-3078

Re: custom-dir is silently skipped if it is not absolute path external-dir works with both absolute and relative path, but custom-dir only with absolute path # more *fact/* :::::::::::::: custom-fact/mycustomfact.rb :::::::::::::: Facter.add('mycustomfact') do setcode do '54321' end end :::::::::::::: external-fact/myfact.txt :::::::::::::: myexternalfact=12345 # facter --external-dir external-fact/ --custom-dir custom-fact/ mycustomfact myexternalfact mycustomfact => myexternalfact => 12345 # facter --external-dir $PWD/external-fact/ --custom-dir $PWD/custom-fact/ mycustomfact myexternalfact mycustomfact => 54321 myexternalfact => 12345   # facter --version 4.2.4

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-3078

Re: custom-dir is silently skipped if it is not absolute path

Agreed Facter 4 should match 3: # /opt/puppetlabs/puppet/bin/facter --version 3.14.23 (commit 46e6e6ffdecff72b75853af43a11acdf2d36752c) # /opt/puppetlabs/puppet/bin/facter --external-dir external-fact/ --custom-dir custom-fact/ mycustomfact myexternalfact

mycustomfact => 54321 myexternalfact => 12345

# /opt/puppetlabs/puppet/bin/facter-ng --version 4.2.8 # /opt/puppetlabs/puppet/bin/facter-ng --external-dir external-fact/ --custom-dir custom-fact/ mycustomfact myexternalfact

mycustomfact => myexternalfact => 12345

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3078

custom-dir is silently skipped if it is not absolute path

Change By: Josh Cooper Team: Night's Watch Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Josh Cooper Fix Version/s: FACT 4.2.13

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Josh Cooper Sprint: Phoenix 2022-09-28

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Josh Cooper Epic Link: PUP-11618

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Josh Cooper Story Points: 1

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Fixes a regression in Facter 4 that prevented the user from specifying a custom directory using a relative path on the command line.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Josh Cooper Release Notes Summary:

Fixes a regression in Facter 4 that prevented the user from specifying a custom directory using a relative path on the command line.

Fix contributed by https://github.com/smortex

Add Comment

[Parker Leach (Jira)]

Parker Leach updated an issue

Facter / FACT-3078 custom-dir is silently skipped if it is not absolute path

Change By: Parker Leach Labels: docs_reviewed

Add Comment