Jira (PDB-4877) Prefer JSON fact terminus for fact cache to YAML

17 views
Skip to first unread message

Justin Stoller (Jira)

unread,
Sep 2, 2020, 2:08:03 PM9/2/20
to puppe...@googlegroups.com
Justin Stoller created an issue
 
PuppetDB / Improvement PDB-4877
Prefer JSON fact terminus for fact cache to YAML
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2020/09/02 11:07 AM
Priority: Normal Normal
Reporter: Justin Stoller

We currently recommend users configure the YAML fact cache when enabling PDB (and we do this configuration for them in PE). We are currently adding a JSON terminus for facts (see PUP-10656) and in Puppet 7 we should switch to enabling it (if we enable any fact caching).

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Justin Stoller (Jira)

unread,
Sep 2, 2020, 2:09:03 PM9/2/20
to puppe...@googlegroups.com

Austin Blatt (Jira)

unread,
Oct 20, 2020, 11:53:03 AM10/20/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Oct 27, 2020, 11:51:03 AM10/27/20
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PDB-4877
 
Re: Prefer JSON fact terminus for fact cache to YAML

See https://github.com/puppetlabs/puppetlabs-puppetdb/blob/master/manifests/master/routes.pp#L10. I don't know if anything needs to change in the puppetdb terminus itself. Perhaps just documentation?

Josh Cooper (Jira)

unread,
Oct 30, 2020, 3:33:03 PM10/30/20
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PDB-4877

One gotcha to watch out for is that symbols are not preserved when round-tripped through JSON. I assume that will not bite us with facts (since the agent sends them as JSON by default on the wire), but it did bite us on the agent when storing resource parameter names in its transactionstore cache, such as :ensure.

Josh Cooper (Jira)

unread,
Nov 3, 2020, 8:09:03 PM11/3/20
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PDB-4877

This looks like a dup of PDB-4945, so I'm going to close it.

Reply all
Reply to author
Forward
0 new messages