Jira (PUP-5073) shellquote() function incorrectly escaping exclamation marks for bash argument usage

Mike Grimes (JIRA)

unread,

Aug 25, 2015, 1:09:04 PM8/25/15

to puppe...@googlegroups.com

Mike Grimes created an issue

Puppet /

PUP-5073

shellquote() function incorrectly escaping exclamation marks for bash argument usage

Issue Type:	Bug
Affects Versions:	the beginning
Assignee:	Unassigned
Components:	DSL
Created:	2015/08/25 10:08 AM
Environment:	ruby 2.0.0p481 (2014-05-08 revision 45883) [universal.x86_64-darwin14] (Mac OSX Yosemite 10.10.5) Puppet v4.2.1
Priority:	Normal
Reporter:	Mike Grimes

Using shellquote() to escape the output from template() of an XML file containing both single quotes and exclamation marks results in exclamation marks being improperly escaped (removing all single quotes results in correct escaping).

Example:

irb(main):011:0> scope.function_shellquote(["!'"])

=> "\"\\!'\""

bash-3.2$ echo "\"\\!'\""

"\!'"

When it should be returned as:

bash-3.2$ echo "\""\!"'\""

"!'"

Add Comment

This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)

Mike Grimes (JIRA)

unread,

Aug 25, 2015, 1:09:17 PM8/25/15

to puppe...@googlegroups.com

Mike Grimes updated an issue

Puppet /

PUP-5073

shellquote() function incorrectly escaping exclamation marks for bash argument usage

Change By:	Mike Grimes

Using shellquote() to escape the output from template() of an XML a file containing both single quotes and exclamation marks results in exclamation marks being improperly escaped (removing all single quotes results in correct escaping).

Example:
{code:shell}

irb(main):011:0> scope.function_shellquote(["!'"])
=> "\"\\!'\""
bash-3.2$ echo "\"\\!'\""
"\!'"

{code}

When it should be returned as:

{code:shell}
bash-3.2$ echo "\""\!"'\""
"!'"
{code}

Add Comment

Mike Grimes (JIRA)

unread,

Aug 25, 2015, 1:17:08 PM8/25/15

to puppe...@googlegroups.com

Mike Grimes commented on

PUP-5073

Re: shellquote() function incorrectly escaping exclamation marks for bash argument usage

I have a fix for this that I'll be submitting soon

Add Comment

Mike Grimes (JIRA)

unread,

Aug 25, 2015, 4:23:03 PM8/25/15

to puppe...@googlegroups.com

Mike Grimes updated an issue

Puppet /

PUP-5073

shellquote() function incorrectly escaping exclamation marks for bash argument usage

Change By:	Mike Grimes

Using shellquote() to escape the output from template() of a file containing both single quotes and exclamation marks results in exclamation marks being improperly escaped (removing all single quotes results in correct escaping).

Example using small sample xml file :
{code:shell}
irb(main): 011 051 :0> print scope.function_shellquote( \
[ "! scope.function_template([ ' " test.xml' ]) ])
"<?xml version = > \ " 1.0 \" ?>
< \ \ ! ' -- \" License\ " ); -->
<description> Using 'local.realm' to be </description>
"=> nil

bash-3.2$ echo " <?xml version= \" 1.0 \ "?>
> < \! ' -- \" License\ " ); -->
> <description> Using 'local.realm' to be </description>
> "
<?xml version="1.0"?>
< \! ' -- " License"); -->
<description> Using 'local.realm' to be </description>

{code}

When it should be returned as:

{code:shell}
bash-3.2$ echo "\""\!"'\""
"!'"
{code}

Add Comment

Mike Grimes (JIRA)

unread,

Aug 25, 2015, 4:23:06 PM8/25/15

to puppe...@googlegroups.com

Mike Grimes updated an issue

Puppet /

PUP-5073

shellquote() function incorrectly escaping exclamation marks for bash argument usage

Change By:	Mike Grimes

Using shellquote() to escape the output from template() of a file containing both single quotes and exclamation marks results in exclamation marks being improperly escaped (removing all single quotes results in correct escaping).

Example using small sample xml file:
{code:shell}

irb(main):051:0> print scope.function_shellquote( \
[scope.function_template(['test.xml'])])
"<?xml version=\"1.0\"?>
<\!-- \"License\"); -->

<description> Using 'local.realm' to be </description>
"=> nil

bash-3.2$ echo "<?xml version=\"1.0\"?>

> <\!-- \"License\"); -->

> <description> Using 'local.realm' to be </description>
> "
<?xml version="1.0"?>

<\!-- "License"); -->

<description> Using 'local.realm' to be </description>
{code}

When it should be returned as:

{code:shell}
bash-3.2$ echo "

<?xml version= \" 1.0\ " ?>
<" \!" ' -- \" License\ " ); -->

<description> Using 'local.realm' to be </description>
"
<?xml version="1.0"?>
< ! ' -- " License"); -->
<description> Using 'local.realm' to be </description>
{code}