Jira (PUP-10955) Environment caches string and symbol environment names differently

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently Issue Type: Bug Assignee: Unassigned Created: 2021/03/08 12:41 PM Priority: Normal Reporter: Josh Cooper The Puppet::Environments::Cached#get method says it accepts Strings or Symbols, but it doesn't normalize the name when getting/setting the environment in the cache. So you can end up caching environments for "production" and :production. Agent side we lookup the environment based on the Puppet[:environment] setting. Server side we lookup the environment from a query parameter. But there are other entry points like Bolt and non-indirected REST APIs, so it would be good to fix this. require 'puppet' Puppet.initialize_settings Puppet::Util::Log.newdestination(:console) Puppet::ApplicationSupport.push_application_context(Puppet::Util::RunMode[:user]) envs = Puppet.lookup(:environments) envs.get!('production') envs.get!(:production) pp envs.instance_variable_get(:@cache).keys $ bx ruby cache.rb ["production", :production] Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Ciprian Badescu Team: Night's Watch

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Ciprian Badescu Sprint: NW-2021-06-30

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Ciprian Badescu Story Points: 2

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes assigned an issue to Luchian Nemes

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Luchian Nemes Assignee: Luchian Nemes

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Josh Cooper Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10955

Re: Environment caches string and symbol environment names differently Merged to 6.x in https://github.com/puppetlabs/puppet/commit/1da11137af2412c531b4337f60debc7ed426122f

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955

Environment caches string and symbol environment names differently

Change By: Ciprian Badescu Sprint: NW-2021-06-30 , NW-2021-07-14

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10955

Re: Environment caches string and symbol environment names differently This was reverted in 6.x in 685cbcc74d and in main in 69e708c80f

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955

Environment caches string and symbol environment names differently

Change By: Ciprian Badescu

Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Victor Bobosila (Jira)]

Victor Bobosila updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Victor Bobosila Fix Version/s: PUP 6.24.0

Add Comment

[Victor Bobosila (Jira)]

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Ciprian Badescu Sprint: NW-2021-06-30, NW-2021-07-14 , NW-2021-07-28

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Ciprian Badescu Epic Link: PUP-10539

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10955

Re: Environment caches string and symbol environment names differently This was unreverted in 6.x in c0071fc4e0 but had to be reverted again in fa308bca3d due to issues with PUP-11158.

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10955

Environment caches string and symbol environment names differently

Change By: Ciprian Badescu Sprint: NW-2021-06-30, NW-2021-07-14, NW-2021-07-28 , NW-2021-08-11

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10955

Re: Environment caches string and symbol environment names differently Merged to 6.x in 082ab3be87

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10955

Environment caches string and symbol environment names differently

Change By: Josh Cooper Fix Version/s: PUP 7.10.0 Fix Version/s: PUP 6.25.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10955

Re: Environment caches string and symbol environment names differently Passed CI in 6ce33c3955

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10955

Environment caches string and symbol environment names differently

Change By: Josh Cooper Release Notes Summary: Previously puppet Fixes a bug that could cache result in puppet caching duplicate copies of an environment depending on how they were loaded .

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Previously puppet could cache duplicate copies of an environment depending on how they were loaded.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10955 Environment caches string and symbol environment names differently

Change By: Claire Cadman Labels: doc-reviewed

Add Comment