Jira (PUP-10314) Puppet tries to print ssl information for non-ssl connections in debug mode

[Josh Cooper (JIRA)]

Josh Cooper created an issue

Puppet / PUP-10314 Puppet tries to print ssl information for non-ssl connections in debug mode Issue Type: Bug Assignee: Unassigned Created: 2020/02/25 2:09 PM Priority: Normal Reporter: Josh Cooper When running in debug mode, puppet tries to print ssl information (protocol & ciphers) for each new connection, but it does it for non-ssl connections. It's unlikely to be triggered in 6.13.0 because only the CA REST APIs and PMT are using the new http client, but can be triggered via:   $ bx puppet module search puppetlabs-stdlib --debug --module_repository=http://localhost:8081/artifactory/api/puppet/puppet Debug: Runtime environment: puppet_version=6.13.0, ruby_version=2.3.8, run_mode=user, default_encoding=UTF-8 Notice: Searching http://localhost:8081/artifactory/api/puppet/puppet ... Debug: Could not find library 'pe_license' required to enable feature 'pe_license' Debug: Creating new connection for http://localhost:8081 Debug: Starting connection for http://localhost:8081 Error: Could not connect to http://localhost:8081/artifactory/api/puppet/puppet There was a network communications problem The error we caught said 'Request to http://localhost:8081/artifactory/api/puppet/puppet/v3/modules?query=puppetlabs-stdlib failed after 0.002 seconds: undefined method `ssl_version' for #<TCPSocket:fd 9>' The problem is a verifier is being passed to the pool in the non-ssl case, and the pool is using that to determine if the connection is ssl based or not. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10314 Puppet tries to print ssl information for non-ssl connections in debug mode

Change By: Josh Cooper Affects Version/s: PUP 6.13.0

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10314 Puppet tries to print ssl information for non-ssl connections in debug mode

Change By: Josh Cooper Fix Version/s: PUP 6.14.0

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10314 Puppet tries to print ssl information for non-ssl connections in debug mode

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-10314 Puppet tries to print ssl information for non-ssl connections in debug mode

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-10314 Puppet tries to print ssl information for non-ssl connections in debug mode

Change By: Josh Cooper Release Notes Summary: In debug mode, Puppet will now only print TLS protocols and ciphersuites for HTTPS connections, but not HTTP connections. Release Notes: Bug Fix

Add Comment

[Melissa Stone (Jira)]

Melissa Stone commented on PUP-10314

Re: Puppet tries to print ssl information for non-ssl connections in debug mode Merged into master with https://github.com/puppetlabs/puppet/commit/7ac0403a6bbc27161ceaf422f022558976e6aee3

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10314

Re: Puppet tries to print ssl information for non-ssl connections in debug mode

Passed CI in e0ec65484c

Add Comment