Jira (PUP-11078) puppet generate types should return non-zero when types cannot be generated

[Ben Ford (Jira)]

Ben Ford created an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated Issue Type: Bug Assignee: Unassigned Created: 2021/06/02 4:44 PM Priority: Normal Reporter: Ben Ford When puppet generate types cannot generate types, it will error, but it explicitly just logs it and keeps going. https://github.com/puppetlabs/puppet/blob/1a13e0cf96c70b303492e684f9ccf4c38207b3dd/lib/puppet/generate/type.rb#L204-L211 [~/.puppetlabs/etc/code/environments/production]$ puppet generate types Notice: Generating Puppet resource types. Error: /Users/ben/.puppetlabs/etc/code/environments/production/modules/drupal/lib/puppet/type/drupal_module.rb: title patterns that use procs are not supported. Error: /Users/ben/.puppetlabs/etc/code/environments/production/modules/drupal/lib/puppet/type/drupal_theme.rb: title patterns that use procs are not supported. Error: /Users/ben/.puppetlabs/etc/code/environments/production/modules/drupal/lib/puppet/type/drupal_variable.rb: title patterns that use procs are not supported. [~/.puppetlabs/etc/code/environments/production]$ echo $? 0 This might be so that code manager doesn't fail when code is deployed, but this is certainly not expected. Should there be an option for explicit error codes? Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Sprint: Triaged tickets

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Mihai Buzgau Team: Night's Watch

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Sprint: Triaged tickets ready for triage 2

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Sprint: ready for triage 2

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Sprint: NW - 2021-11-17

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Story Points: 2

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Sprint: NW - 2021- 11 12 - 17 01(02)

Add Comment

[Victor Bobosila (Jira)]

Victor Bobosila assigned an issue to Victor Bobosila

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Victor Bobosila Assignee: Victor Bobosila

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Sprint: NW - 2021-12-06 , NW - 2021-12-17

Add Comment

[Victor Bobosila (Jira)]

Victor Bobosila updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Victor Bobosila Release Notes: Bug Fix

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Victor Bobosila (Jira)]

Victor Bobosila updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Victor Bobosila Release Notes Summary: Fix an issue where puppet generate would return an exit code with the value of 0 even when failing to generate a new custom type by creating a new Puppet::Generator method that checks whether a type has raised an error or not

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Ciprian Badescu Sprint: NW - 2021-12-06, NW - 2021-12-17 , NW - 2022-01-04

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Josh Cooper Fix Version/s: PUP 6.26.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Josh Cooper Fix Version/s: PUP 7.14.0

Add Comment

[Heston Hoffman (Jira)]

Heston Hoffman updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Heston Hoffman Labels: docs-reviewed

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11078 puppet generate types should return non-zero when types cannot be generated

Change By: Josh Cooper Fix Version/s: 7.15.0

Add Comment