Jira (FACT-3162) Facter 4 reports os.name as "SLES_SAP" on Suse Linux for SAP instead of just "SUSE"

16 views
Skip to first unread message

Aaron Hilton (Jira)

unread,
Oct 21, 2022, 4:15:14 PM10/21/22
to puppe...@googlegroups.com
Aaron Hilton created an issue
 
Facter / Bug FACT-3162
Facter 4 reports os.name as "SLES_SAP" on Suse Linux for SAP instead of just "SUSE"
Issue Type: Bug Bug
Affects Versions: FACT 4.2.8
Assignee: Unassigned
Components: Facter 4
Created: 2022/10/21 1:14 PM
Priority: Normal Normal
Reporter: Aaron Hilton

I am not sure that this is a "functioning as designed" issue as much as it is a "is this best for our customers" issue, however on SLES for SAP systems, Facter 4 returns "SLES_SAP" for the OS Name rather than "SLES". This is functioning as designed, as the /etc/os-release file does have "SLES_SAP" as the name string in /etc/os-release as seen in the following snip...

 NAME="SLES_SAP"
    VERSION="12-SP1"
    VERSION_ID="12.1.0.1"
    PRETTY_NAME="SUSE Linux Enterprise Server for SAP Applications 12 SP1"
    ID="sles_sap"
    ANSI_COLOR="0;32"
    CPE_NAME="cpe:/o:suse:sles_sap:12:sp1"

The concern is that since this is returning something other then "SLES", this variant of SLES will not work with much of the code released in the Forge or custom code without refactoring the modules to take this version of SLES into account.

Also the customer is reporting that on several of their SLES 12.2 for SAP systems the os.release.major fact is resolving to “12.2” and not “12" while “os.distro.release.major” correctly resolves to “12". This fact comes back correct on a SLES 12SP5 box. There appears to be a difference in the format of the VERSION_ID between SAP and non-SAP versions of SLES. Maybe we need to adjust how we are splitting the VERSION_ID.

Perhaps the better discussion is if SLES for SAP is a supported OS...

 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Alvin Rodis (Jira)

unread,
Oct 21, 2022, 4:16:03 PM10/21/22
to puppe...@googlegroups.com

Alvin Rodis (Jira)

unread,
Oct 21, 2022, 4:16:03 PM10/21/22
to puppe...@googlegroups.com
Alvin Rodis updated an issue
Change By: Alvin Rodis
Zendesk Ticket Count: 1
Zendesk Ticket IDs: 49987

Morgan Rhodes (Jira)

unread,
Oct 25, 2022, 4:24:01 PM10/25/22
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Oct 25, 2022, 5:02:06 PM10/25/22
to puppe...@googlegroups.com
Josh Cooper commented on Bug FACT-3162
 
Re: Facter 4 reports os.name as "SLES_SAP" on Suse Linux for SAP instead of just "SUSE"

Facter 3.x used to apply these regular expressions to normalize the SUSE name:

https://github.com/puppetlabs/facter/blob/6d7ffc6efdfbc3b1fc79311cdeb4581ac2098d9c/lib/src/facts/linux/os_linux.cc#L130-L132

I'd expect Facter 4 to do the same. In addition the "os.release" facts are reported differently between 6.22.1 and 7.18.0:

$ cat 6.22.1.json | jq '.[].facts.os.release'      
{
  "full": "12.1",
  "major": "12",
  "minor": "1"
}
$ cat 7.18.0.json | jq '.[].facts.os.release' 
{
  "full": "12.1.0.1",
  "major": "12"
}

Aaron Hilton (Jira)

unread,
Oct 28, 2022, 4:52:03 PM10/28/22
to puppe...@googlegroups.com
Aaron Hilton updated an issue
 
Change By: Aaron Hilton
Attachment: SLES4SAP12SP1_os_release
Attachment: facter_4_2_11_out.txt
Attachment: facter_3_14_24_out.txt

Josh Cooper (Jira)

unread,
Jan 9, 2023, 12:37:16 PM1/9/23
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Apr 24, 2023, 2:31:02 PM4/24/23
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages