Jira (FACT-2059) premature loading of module-provided facts under `-p`

16 views
Skip to first unread message

David Schmitt (JIRA)

unread,
Oct 7, 2019, 1:31:03 PM10/7/19
to puppe...@googlegroups.com
David Schmitt created an issue
 
Facter / Bug FACT-2059
premature loading of module-provided facts under `-p`
Issue Type: Bug Bug
Assignee: Unassigned
Attachments: 2019-10-07_18MS+0100_2069x1151.png
Created: 2019/10/07 10:30 AM
Environment:

ciscopuppet module, facter 3.13.2 (commit a34181878), windows 2016 x64 (gnocchi.platform9.puppet.net)

Priority: Normal Normal
Reporter: David Schmitt

When running facter -p on windows with the puppetlabs/ciscopuppet module pluginsynced to the agent, facter is loading facter/cisco.rb from C:/ProgramData/PuppetLabs/puppet/cache/lib before setting up the $LOAD_PATH to load that file's dependencies from there. Please see the attached screenshot for the debug modifications I did and the results on the machine showing the issue.

To make sure there is nothing wonky with the facter/cisco_nexus file itself, a require within a setcode worked fine.

Regular agent runs work fine and do not show any errors.

Desired Behaviour

facter -p loads files from puppet's cache only once, after $LOAD_PATH has been properly initialised.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

David Schmitt (JIRA)

unread,
Oct 7, 2019, 1:33:02 PM10/7/19
to puppe...@googlegroups.com
David Schmitt updated an issue
Change By: David Schmitt
Affects Version/s: FACT 3.13.2

Mihai Buzgau (JIRA)

unread,
Oct 8, 2019, 8:53:03 AM10/8/19
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Oct 8, 2019, 8:54:03 AM10/8/19
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Oct 16, 2019, 5:01:02 AM10/16/19
to puppe...@googlegroups.com

Mihai Buzgau (JIRA)

unread,
Oct 16, 2019, 5:01:03 AM10/16/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR NW - Triage 2019-10-30

George Mrejea (JIRA)

unread,
Oct 22, 2019, 4:22:03 AM10/22/19
to puppe...@googlegroups.com
George Mrejea updated an issue
Change By: George Mrejea
When running {{facter -p}} on windows with the puppetlabs/ciscopuppet module pluginsynced to the agent, facter is loading {{facter/cisco.rb}} from {{C:/ProgramData/PuppetLabs/puppet/cache/lib}} before setting up the {{$LOAD_PATH}} to load that file's dependencies from there. Please see the attached screenshot for the debug modifications I did and the results on the machine showing the issue.

To make sure there is nothing wonky with the {{facter/cisco_nexus}} file itself, a {{require}} within a {{setcode}} worked fine.

Regular agent runs work fine and do not show any errors.

h3. Desired Behaviour


{{facter -p}} loads files from puppet's cache only once, after {{$LOAD_PATH}} has been properly initialised.

George Mrejea (JIRA)

unread,
Oct 22, 2019, 4:32:03 AM10/22/19
to puppe...@googlegroups.com

George Mrejea (JIRA)

unread,
Oct 22, 2019, 4:58:03 AM10/22/19
to puppe...@googlegroups.com
George Mrejea assigned an issue to Unassigned

Mihai Buzgau (JIRA)

unread,
Oct 30, 2019, 5:00:13 AM10/30/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2019-10-30 , NW - 2019-11-13

Mihai Buzgau (JIRA)

unread,
Nov 11, 2019, 4:19:04 AM11/11/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages