Jira (PUP-8770) Puppet resource service status should be more than binary

13 views
Skip to first unread message

Paul Schaffer (JIRA)

unread,
May 22, 2018, 3:33:03 PM5/22/18
to puppe...@googlegroups.com
Paul Schaffer created an issue
 
Puppet / Improvement PUP-8770
Puppet resource service status should be more than binary
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2018/05/22 12:32 PM
Priority: Normal Normal
Reporter: Paul Schaffer

When the Puppet Agent runs during boot (or at other times, during changes of various sorts), some services may still be starting, which means they show a different state than "active" for the service units.

When Puppet runs, it tries to enforce

{ ensure=>running , enable => true}

on the Service resource, which ends up restarting the already-starting service.

For example, when restarting a host running a MariaDB Galera cluster, MariaDB is in the process of "catching up" with the cluster (via IST) when Puppet restarts it. That ends up breaking the incremental updates, requiring the node to take even longer to start up again by doing a full SST (which also makes another node in the cluster unavailable at that time).

The desired behavior is that Puppet would see that the service is already in the process of starting, and do nothing, or possibly just log a warning.

A similar issue likely exists for services which are in the process of stopping.

The command `systemctl status is-active mariadb.service` returns this output in these states:

  • active (exit code 0) – normal "fully started" state
  • inactive (exit code 3) – fully stopped
  • deactivating (exit code 3) – in the process of stopping
  • activating (exit code 3) – in the process of starting

Puppet is simply leveraging an exit code of 0 or nonzero to determine the state, but it should probably be interpreting the actual state, through the contents of STDOUT from `systemctl is-active $SERVICE_NAME` for instance, so that it can properly handle these other states.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Adam Bottchen (JIRA)

unread,
May 24, 2018, 7:09:03 PM5/24/18
to puppe...@googlegroups.com
Adam Bottchen updated an issue
Change By: Adam Bottchen
CS Priority: Needs Priority Reviewed

Craig Gomes (JIRA)

unread,
May 29, 2018, 12:47:02 PM5/29/18
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 11, 2020, 2:26:03 AM6/11/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity Night's Watch
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 11, 2020, 2:26:03 AM6/11/20
to puppe...@googlegroups.com

Mihai Buzgau (Jira)

unread,
Jun 16, 2020, 10:54:03 AM6/16/20
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Nov 5, 2020, 3:51:04 AM11/5/20
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Nov 5, 2020, 3:52:04 AM11/5/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 11, 2021, 10:18:03 PM6/11/21
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-8770
 
Re: Puppet resource service status should be more than binary

There are a number of issues in this area for different services, see PUP-4993, PUP-5474, PUP-6254

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Ciprian Badescu (Jira)

unread,
Oct 21, 2021, 8:17:02 AM10/21/21
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages