Jira (PUP-11322) Excessive copying of already merged code for hostclasses

2 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Oct 15, 2021, 1:30:02 PM10/15/21
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-11322
Excessive copying of already merged code for hostclasses
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2021/10/15 10:29 AM
Priority: Normal Normal
Reporter: Josh Cooper

When parsing manifests, we merge the main hostclass' code. Each merge creates a new BlockExpression containing the children from the old and new codes. This means we're copying the children from the already merged code N times and the array gets bigger each time. This accounts for about 11MB when running the many_modules benchmark with 100 iterations.

It seems like we should be appending the new code with the already merged code.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages