Jira (PUP-11723) Remove dependency on private class Concurrent::RubyThreadLocalVar

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar Change By: Josh Cooper Summary: Revisit Remove dependency on private class Concurrent::RubyThreadLocalVar Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar Change By: Josh Cooper

Puppet relies on the Concurrent::RubyThreadLocalVar class which was removed in 1.2.0, see https://github.com/ruby-concurrency/concurrent-ruby/issues/986#issuecomment-1400997040 We explicitly rely on the Ruby implementation when running on JRuby because of a bug, see PUP-9931 and https://github.com/puppetlabs/puppet/commit/9182bc3dd2576f409a6d01fb5c08d392670e90a2 For now we've pinned back to < 1.2 (PUP-11722) but we should look into not relying on a private class and remove our concurrent-ruby pin. Grooming: * Replace removed class with Concurrent::ThreadLocalVar, see commit where RubyThreadLocalVar was removed https://github.com/ruby-concurrency/concurrent-ruby/commit/30465396

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar Change By: Josh Cooper

Puppet relies on the Concurrent::RubyThreadLocalVar class which was removed in 1.2.0, see https://github.com/ruby-concurrency/concurrent-ruby/issues/986#issuecomment-1400997040 We explicitly rely on the Ruby implementation when running on JRuby because of a bug, see PUP-9931 and https://github.com/puppetlabs/puppet/commit/9182bc3dd2576f409a6d01fb5c08d392670e90a2 For now we've pinned back to < 1.2 (PUP-11722) but we should look into not relying on a private class and remove our concurrent-ruby pin. Grooming: * Replace removed class with Concurrent::ThreadLocalVar, see commit where RubyThreadLocalVar was removed https://github.com/ruby-concurrency/concurrent-ruby/commit/30465396

* Spec tests should pass on MRI and JRuby * Change should be made in 7.x and main

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar

Change By: Josh Cooper Story Points: 2

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar Change By: Josh Cooper

Puppet relies on the Concurrent::RubyThreadLocalVar class which was removed in 1.2.0, see https://github.com/ruby-concurrency/concurrent-ruby/issues/986#issuecomment-1400997040 We explicitly rely on the Ruby implementation when running on JRuby because of a bug, see PUP-9931 and https://github.com/puppetlabs/puppet/commit/9182bc3dd2576f409a6d01fb5c08d392670e90a2 For now we've pinned back to < 1.2 (PUP-11722) but we should look into not relying on a private class and remove our concurrent-ruby pin. Grooming: * Replace removed class with Concurrent::ThreadLocalVar, see commit where RubyThreadLocalVar was removed https://github.com/ruby-concurrency/concurrent-ruby/commit/30465396 * Spec tests should pass on MRI and JRuby

* Change should be made in both 7.x and main * Restore concurrent-ruby gem dependency to {{~> 1.0}} in both .gemspec and ext/project_data.yaml The change must be made in two places due to PA-5400.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar

Change By: Josh Cooper Fix Version/s: PUP 8.1.0 Fix Version/s: PUP 7.25.0

Add Comment

[Tony Vu (Jira)]

Tony Vu updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar

Change By: Tony Vu Sprint: Phoenix 2023-05-24

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume assigned an issue to Michael Hashizume

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar

Change By: Michael Hashizume Assignee: Michael Hashizume

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar

Change By: Michael Hashizume Sprint: Phoenix 2023-05-24 , Phoenix 2023-06-07

Add Comment

This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar

Change By: Michael Hashizume Release Notes: Bug Fix Release Notes Summary: The Puppet::ThreadLocal class no longer relies on concurrent-ruby's private Concurrent::RubyThreadLocalVar class and instead uses Concurrent::ThreadLocalVar.

Add Comment

[Parker Leach (Jira)]

Parker Leach updated an issue

Puppet / PUP-11723 Remove dependency on private class Concurrent::RubyThreadLocalVar

Change By: Parker Leach Labels: docs_reviewed

Add Comment