Jira (PUP-8305) Git testing should consume the runtime archive rather than install system packages

2 views
Skip to first unread message

Melissa Stone (JIRA)

unread,
Jan 3, 2018, 4:48:04 PM1/3/18
to puppe...@googlegroups.com
Melissa Stone created an issue
 
Puppet / Task PUP-8305
Git testing should consume the runtime archive rather than install system packages
Issue Type: Task Task
Assignee: Unassigned
Created: 2018/01/03 1:47 PM
Priority: Normal Normal
Reporter: Melissa Stone

We currently have work scheduled to build out all required runtime components (ruby, openssl, etc), and make them available to grab during build time of puppet-agent. We should be able to leverage this to make our git-based testing faster and easier as well. This will be internal only for the moment (maybe, depending on Artifactory settings, once the package is consistently shipping to Artifactory), but that's fine.

We should replace the logic in 00_EnvSetup.rb that installs these runtime components from system packages with the runtime archive. This will alleviate a lot of headache for developers trying to test subcomponents with git.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Melissa Stone (JIRA)

unread,
Feb 5, 2018, 1:25:03 PM2/5/18
to puppe...@googlegroups.com
Melissa Stone updated an issue
Change By: Melissa Stone
Fix Version/s: PUP 4.10.z
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

Josh Cooper (JIRA)

unread,
Apr 2, 2018, 11:49:03 AM4/2/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 4.10.11
Fix Version/s: PUP 4.10.z
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Melissa Stone (JIRA)

unread,
Apr 4, 2018, 11:42:02 AM4/4/18
to puppe...@googlegroups.com
Melissa Stone commented on Task PUP-8305
 
Re: Git testing should consume the runtime archive rather than install system packages

Josh Cooper we should be able to start this now that the runtime packages are in use, yes?

Josh Cooper (JIRA)

unread,
Apr 4, 2018, 12:08:04 PM4/4/18
to puppe...@googlegroups.com

Melissa Stone (JIRA)

unread,
Apr 10, 2018, 12:06:06 PM4/10/18
to puppe...@googlegroups.com

Melissa Stone (JIRA)

unread,
Jun 26, 2018, 6:59:02 PM6/26/18
to puppe...@googlegroups.com

Melissa Stone (JIRA)

unread,
Jun 26, 2018, 6:59:05 PM6/26/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Jul 9, 2018, 10:17:05 AM7/9/18
to puppe...@googlegroups.com

Melissa Stone (JIRA)

unread,
Jul 9, 2018, 1:38:03 PM7/9/18
to puppe...@googlegroups.com
Melissa Stone updated an issue
Change By: Melissa Stone
Fix Version/s: PUP 4.10.z
Fix Version/s: PUP 6.y

Melissa Stone (JIRA)

unread,
Jul 9, 2018, 1:38:04 PM7/9/18
to puppe...@googlegroups.com
Melissa Stone commented on Task PUP-8305
 
Re: Git testing should consume the runtime archive rather than install system packages

This work isn't tied to a specific release and should not be a release blocker at all. It's isolated to testing changes. Should I remove the impediment flag? I've also been doing this work with the master branch, rather than anything earlier, so I'll change the fix version accordingly

Kenn Hussey (JIRA)

unread,
Jul 9, 2018, 1:52:03 PM7/9/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Jul 9, 2018, 1:55:04 PM7/9/18
to puppe...@googlegroups.com
Kenn Hussey commented on Task PUP-8305
 
Re: Git testing should consume the runtime archive rather than install system packages

Thanks, Melissa Stone, I removed the flag. Does this issue (as well as PUP-8306) really block PUP-4543 (or should it perhaps be retargeted as well)?

Rob Braden (JIRA)

unread,
Jul 9, 2018, 4:39:03 PM7/9/18
to puppe...@googlegroups.com
Rob Braden updated an issue
 
Change By: Rob Braden
Fix Version/s: PUP 6.y
Fix Version/s: PUP 5.y

Melissa Stone (JIRA)

unread,
Jul 23, 2018, 4:36:05 PM7/23/18
to puppe...@googlegroups.com

Melissa Stone (JIRA)

unread,
Jul 23, 2018, 4:45:04 PM7/23/18
to puppe...@googlegroups.com
Melissa Stone commented on Task PUP-8305
 
Re: Git testing should consume the runtime archive rather than install system packages

Current status: Pre-suite passes on everything except sles11 (tls issues cloning the git repo).

Full acceptance suite summary:

passed
--------
redhat7-64a
sles12-64a
solaris11-64a
ubuntu1604-64a
debian8-64a
 
failed
--------
sles11-64a -> git binary doesn't have the right tls creds
osx1011-64a -> we don't make tarballs for the master branch, too old
osx1012-64a
    failed:
        tests/config/apply_file_metadata_specified_in_config.rb:41
        tests/environment/variables_refreshed_each_compilation.rb:60
    errored:
        tests/ssl/certificate_extensions.rb:74
        tests/ssl/ticket_5274_private_key_modes.rb:27
        tests/ssl/autosign_command.rb:60
        tests/ticket_3961_puppet_ca_should_produce_certs.rb:25
        
osx1013
    failed:
        tests/config/apply_file_metadata_specified_in_config.rb:41
        tests/environment/variables_refreshed_each_compilation.rb:60
    errored:
        tests/ssl/certificate_extensions.rb:74
        tests/ssl/ticket_5274_private_key_modes.rb:27
        tests/ssl/autosign_command.rb:60
        tests/resource/user/should_allow_password_salt_iterations_osx.rb:31
        tests/ticket_3961_puppet_ca_should_produce_certs.rb:25
 
solaris10-64a -> this should be fixed now
      Test Case tests/environment/variables_refreshed_each_compilation.rb reported: #<Beaker::DSL::Outcomes::FailTest:
    first custom time was not as expected.
    Expected /Notice: local_(\d+)_local/ to match "\e[0;32mInfo: Using configured environment 'variables_refreshed_each_compilation_2jqtac0o'\e[0m\n\e[0;32mInfo: Retrieving pluginfacts\e[0m\n\e[0;32mInfo: Retriev
    ing plugin\e[0m\n\e[0;32mInfo: Retrieving locales\e[0m\n\e[0;32mInfo: Caching catalog for cl5xa4d7z9an580.delivery.puppetlabs.net\e[0m\n\e[0;32mInfo: Applying configuration version '1531187226'\e[0m\n\e[mNoti
    ce: local_%s%N_local\e[0m\n\e[mNotice: /Stage[main]/Foo::Bar/Notify[local_%s%N_local]/message: defined 'message' as 'local_%s%N_local'\e[0m\n\e[mNotice: module_%s%N_module\e[0m\n\e[mNotice: /Stage[main]/Custo
    m_time/Notify[custom time]/message: defined 'message' as 'module_%s%N_module'\e[0m\n\e[mNotice: Applied catalog in 0.11 seconds\e[0m\n".
    >   Test line: tests/environment/variables_refreshed_each_compilation.rb:60:in `block (3 levels) in run_test'
 
windows2012r2-64a
    Failed Tests Cases:
  Test Case tests/windows/env_windows_installdir_fact.rb reported: #<Minitest::Assertion: env_windows_installdir fact did not match expected output.
--- expected
+++ actual
@@ -1 +1 @@
-"C:\\Program Files\\Puppet Labs\\Puppet"
+nil
>
    Test line: tests/windows/env_windows_installdir_fact.rb:26:in `block (5 levels) in run_test'
Errored Tests Cases:
  Test Case tests/modulepath.rb reported: #<Beaker::Host::CommandFailure: Host 'nrm0x33a8f05sbf.delivery.puppetlabs.net' exited with 1 running:
 cmd.exe /c bundle exec puppet apply -e "beacon { 'ping': }"
Last 10 lines of output were:
        Error: Evaluation Error: Error while evaluating a Resource Statement, Unknown resource type: 'beacon' (line: 1, column: 1) on node nrm0x33a8f05sbf.del
ivery.puppetlabs.net>
    Test line: tests/modulepath.rb:70:in `block (4 levels) in run_test'

Josh Cooper (JIRA)

unread,
Aug 7, 2018, 12:37:03 PM8/7/18
to puppe...@googlegroups.com

Melissa Stone (JIRA)

unread,
Aug 8, 2018, 7:58:02 PM8/8/18
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Oct 10, 2018, 1:06:04 PM10/10/18
to puppe...@googlegroups.com

Jonathan Morris (JIRA)

unread,
Oct 23, 2018, 4:24:04 PM10/23/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Oct 24, 2018, 3:49:02 PM10/24/18
to puppe...@googlegroups.com
Kenn Hussey updated an issue
Change By: Kenn Hussey
Fix Version/s: PUP 6.0.3
Fix Version/s: PUP 6.0.z

Melissa Stone (JIRA)

unread,
Oct 29, 2018, 4:28:05 PM10/29/18
to puppe...@googlegroups.com
Melissa Stone commented on Task PUP-8305
 
Re: Git testing should consume the runtime archive rather than install system packages

The beaker-puppet PR has been merged. We need to cut a release of this, then we can see how it does in the pipelines

Josh Cooper (JIRA)

unread,
Nov 1, 2018, 1:02:03 AM11/1/18
to puppe...@googlegroups.com

Melissa Stone (JIRA)

unread,
Nov 5, 2018, 4:25:04 PM11/5/18
to puppe...@googlegroups.com
Melissa Stone commented on Task PUP-8305

I cut beaker-puppet 1.8.0 which includes this change. I'd like to wait until we get a ci run with this updated version of beaker-puppet to resolve this ticket.

Melissa Stone (JIRA)

unread,
Nov 6, 2018, 1:57:05 PM11/6/18
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Jul 15, 2019, 7:51:03 PM7/15/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Fix Version/s: PUP 6.0.z
Fix Version/s: PUP 5.y
Reply all
Reply to author
Forward
0 new messages