Jira (PUP-10898) Get fully qualified current domain user name

[Luchian Nemes (Jira)]

Luchian Nemes created an issue

Puppet / PUP-10898 Get fully qualified current domain user name Issue Type: Task Affects Versions: PUP 6.14.0 Assignee: Luchian Nemes Created: 2021/02/11 6:54 AM Priority: Normal Reporter: Luchian Nemes In some cases, looking up non fully qualified user names (just 'name' instead of 'DOMAIN name') on Windows does not work. In this case, Puppet Agent fails with Error: Failed to apply catalog: undefined method `bytesize' for nil:NilClass.   The issue was narrowed down to https://github.com/puppetlabs/puppet/blob/main/lib/puppet/util/windows/principal.rb#L47 which silently fails with Failed to get user name: No mapping between account names and security IDs was done.   Using https://docs.microsoft.com/en-us/windows/win32/api/secext/nf-secext-getusernameexw instead of https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getusernamew in https://github.com/puppetlabs/puppet/blob/main/lib/puppet/util/windows/adsi.rb#L489 or https://github.com/puppetlabs/puppet/blob/6.x/lib/puppet/file_system/windows.rb#L130 with the correct format should sove the issue.     Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Luchian Nemes (Jira)]

Luchian Nemes updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Luchian Nemes In some cases, looking up non fully qualified user names (just '*name*' instead of '*DOMAIN \\ * * name*') on Windows does not work. In this case, Puppet Agent fails with *Error: Failed to apply catalog: undefined method `bytesize' for nil:NilClass*.   The issue was narrowed down to [https://github.com/puppetlabs/puppet/blob/main/lib/puppet/util/windows/principal.rb#L47] which silently fails with *Failed to get user name: No mapping between account names and security IDs was done.*

Using [https://docs.microsoft.com/en-us/windows/win32/api/secext/nf-secext-getusernameexw] instead of [https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getusernamew] in [https://github.com/puppetlabs/puppet/blob/main/lib/puppet/util/windows/adsi.rb#L489] or [https://github.com/puppetlabs/puppet/blob/6.x/lib/puppet/file_system/windows.rb#L130] with the correct format should sove the issue.

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes assigned an issue to Unassigned

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Luchian Nemes Assignee: Luchian Nemes

Add Comment

[zendesk.jira (Jira)]

zendesk.jira updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: zendesk.jira Labels: jira_escalated

Add Comment

[zendesk.jira (Jira)]

zendesk.jira updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: zendesk.jira Zendesk Ticket Count: 1 Zendesk Ticket IDs: 42708

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10898

Get fully qualified current domain user name

Change By: Mihai Buzgau Issue Type: Task Improvement

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Mihai Buzgau Team: Night's Watch

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Mihai Buzgau Sprint: NW - 2021-03-03

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Gheorghe Popescu Story Points: 3 2

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes assigned an issue to Luchian Nemes

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Luchian Nemes Assignee: Luchian Nemes

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Josh Cooper Fix Version/s: PUP 7.5.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Josh Cooper Fix Version/s: PUP 6.22.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10898

Re: Get fully qualified current domain user name Merged to 6.x in ce0216f31f, passed CI in 2056487938

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes updated an issue

Puppet / PUP-10898

Get fully qualified current domain user name

Change By: Luchian Nemes Release Notes: Bug Fix Release Notes Summary: Retrieving the current user name SID on Windows was causing Puppet to fail in certain scenarios where the user was from a secondary domain controller. A fallback mechanism was implemented to use the fully qualified domain name for lookup.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10898 Get fully qualified current domain user name

Change By: Claire Cadman Labels: doc_reviewed jira_escalated

Add Comment