Jira (PUP-11723) Revisit Concurrent::RubyThreadLocalVar

14 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jan 23, 2023, 4:57:05 PM1/23/23
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-11723
Revisit Concurrent::RubyThreadLocalVar
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2023/01/23 1:56 PM
Priority: Normal Normal
Reporter: Josh Cooper

Puppet relies on the Concurrent::RubyThreadLocalVar class which was removed in 1.2.0, see https://github.com/ruby-concurrency/concurrent-ruby/issues/986#issuecomment-1400997040

For now we've pinned back to 1.1.x (PUP-11722) but we should look into not relying on a private class and remove our concurrent-ruby pin.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
Jan 25, 2023, 12:37:03 PM1/25/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Puppet relies on the Concurrent::RubyThreadLocalVar class which was removed in 1.2.0, see https://github.com/ruby-concurrency/concurrent-ruby/issues/986#issuecomment-1400997040

For now we've pinned back to < 1. 1.x 2 (PUP-11722) but we should look into not relying on a private class and remove our concurrent-ruby pin.

Josh Cooper (Jira)

unread,
Jan 25, 2023, 12:39:03 PM1/25/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Puppet relies on the Concurrent::RubyThreadLocalVar class which was removed in 1.2.0, see https://github.com/ruby-concurrency/concurrent-ruby/issues/986#issuecomment-1400997040

We explicitly rely on the Ruby implementation when running on JRuby because of a bug, see PUP-9931 and https://github.com/puppetlabs/puppet/commit/9182bc3dd2576f409a6d01fb5c08d392670e90a2

For now we've pinned back to < 1.2 (PUP-11722) but we should look into not relying on a private class and remove our concurrent-ruby pin.

Josh Cooper (Jira)

unread,
Mar 17, 2023, 12:55:02 PM3/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-11659

Josh Cooper (Jira)

unread,
Mar 21, 2023, 9:48:02 PM3/21/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Priority: Normal High
Reply all
Reply to author
Forward
0 new messages