Jira (PUP-10929) Syntax error in previously valid puppet code due to removal of application orchestration keywords

[Alexander Fisher (Jira)]

Alexander Fisher created an issue

Puppet / PUP-10929 Syntax error in previously valid puppet code due to removal of application orchestration keywords Issue Type: Bug Affects Versions: PUP 7.4.1 Assignee: Unassigned Components: Language Created: 2021/02/22 7:15 AM Priority: Normal Reporter: Alexander Fisher Puppet Version: 7.4.1 class foo ( $site, ) { notice $site }   class { foo: site => 'bar', # syntax error on this line in puppet 7 }   The above code works fine in Puppet 4, 5 and 6 despite `site` being on the list of reserved words here. https://puppet.com/docs/puppet/7.4/lang_reserved.html#lang_reserved_words Actual Behavior: Error: Could not parse for environment production: Syntax error at 'site' (file: /home/halexfis/test.pp, line: 8, column: 3) on node test https://puppet.com/docs/puppet/7.4/lang_reserved.html#lang_reserved_words doesn't explicitly say you can't use these words as parameter names, and other examples from that list continue to work fine. (eg. 'node'). It looks like this regression was caused by https://tickets.puppetlabs.com/browse/PUP-10446   Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Puppet / PUP-10929 Syntax error in previously valid puppet code due to removal of application orchestration keywords

Change By: Gabriel Nagy Labels: community

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10929 Syntax error in previously valid puppet code due to removal of application orchestration keywords

Change By: Mihai Buzgau Team: Night's Watch

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10929 Syntax error in previously valid puppet code due to removal of application orchestration keywords

Change By: Mihai Buzgau Sprint: NW - 2021-03-17

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10929

Re: Syntax error in previously valid puppet code due to removal of application orchestration keywords Adding Henrik Lindberg comment from https://puppetcommunity.slack.com/archives/C0W1X7ZAL/p1614006476005200 there is a list of keywords that are allowed, I suspect it is missing from that list (and probably also the other keywords related to orchestration).

Add Comment

[Henrik Lindberg (Jira)]

Henrik Lindberg commented on PUP-10929

Re: Syntax error in previously valid puppet code due to removal of application orchestration keywords

Josh Cooper It is this part of the grammar: attribute_name : NAME | keyword and keyword is a rule with a list of tokens. The tokens for the now reserved keywords must be on that list to make them ok to use as names of resource attributes or the result is the reported "syntax error".

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10929

Re: Syntax error in previously valid puppet code due to removal of application orchestration keywords

Henrik Lindberg What's the benefit to keeping those keywords reserved? It's not like someone can turn application orchestration back on. It sounds like our options are: 1. Remove site, etc keywords from the reserved list, OR 2. Update the grammar to accept the reserved keywords and regenerate the eparser. See af9b8e0894c2d606e81671fb133d4ef73d9ed7ef and de9c2b3b01ae7202ef441da0dbc41108b8ca013a.

Add Comment

[Henrik Lindberg (Jira)]

Henrik Lindberg commented on PUP-10929

Re: Syntax error in previously valid puppet code due to removal of application orchestration keywords

Josh Cooper The benefit of keeping them reserved is that you may want to use them in the future for something other than the now removed application orchestration and it takes a major release to get there plus a lot of pain for users if they again would be put to use if they had been free to use for a while. You are right about the options.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10929

Syntax error in previously valid puppet code due to removal of application orchestration keywords

Change By: Josh Cooper Fix Version/s: PUP 7.5.0

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10929 Syntax error in previously valid puppet code due to removal of application orchestration keywords

Change By: Mihai Buzgau Story Points: 2

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu assigned an issue to Ciprian Badescu

Puppet / PUP-10929 Syntax error in previously valid puppet code due to removal of application orchestration keywords

Change By: Ciprian Badescu Assignee: Ciprian Badescu

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10929

Re: Syntax error in previously valid puppet code due to removal of application orchestration keywords Merged to main in https://github.com/puppetlabs/puppet/commit/64dcad64c71f8a2c2648ab88262df40bb9622525

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10929

Syntax error in previously valid puppet code due to removal of application orchestration keywords

Change By: Claire Cadman Labels: community doc_reviewed

Add Comment