Jira (PUP-5687) resources type takes long time to evaluate

10 views
Skip to first unread message

buck huppmann (JIRA)

unread,
Jan 12, 2016, 8:21:15 AM1/12/16
to puppe...@googlegroups.com
buck huppmann updated an issue
 
Puppet / Improvement PUP-5687
resources type takes long time to evaluate
Change By: buck huppmann
Summary: resources type takes long time to  evalutes  evaluate
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
Atlassian logo

buck huppmann (JIRA)

unread,
Jan 12, 2016, 8:41:03 AM1/12/16
to puppe...@googlegroups.com
buck huppmann assigned an issue to buck huppmann
Change By: buck huppmann
Assignee: buck huppmann

Henrik Lindberg (JIRA)

unread,
Jan 12, 2016, 10:03:03 AM1/12/16
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-5687
 
Re: resources type takes long time to evaluate

buck huppmann You assigned this ticket to yourself ad it is in "open" mode - are you planning to amend the report, supply a PR, or what's up ??
(I understand you may not know the workflow we are using - but the ticket is now owned by the Client team, and they should make an assessment and move the ticket to "accepted", "ready for engineering", or possibly "closed". We use "needs information" state and assignment to a user when ticket is blocked on information/decision on that user. Tickets just waiting for someone to have time are typically unassigned).

What you have found looks valuable to investigate - more speed is always welcome. Ping Kylo Ginsberg

buck huppmann (JIRA)

unread,
Jan 12, 2016, 10:28:14 AM1/12/16
to puppe...@googlegroups.com
buck huppmann commented on Improvement PUP-5687

my fault

as the history shows, i am having some user issues with the JIRA web UI;
any change i made to ticket/issue data, besides editing comments, has
been totally inadvertent, so please correct

Henrik Lindberg (JIRA)

unread,
Jan 12, 2016, 11:20:06 AM1/12/16
to puppe...@googlegroups.com
Henrik Lindberg assigned an issue to Unassigned
 
Change By: Henrik Lindberg
Assignee: buck huppmann

Kylo Ginsberg (JIRA)

unread,
Jan 12, 2016, 4:27:03 PM1/12/16
to puppe...@googlegroups.com
Kylo Ginsberg commented on Improvement PUP-5687
 
Re: resources type takes long time to evaluate

buck huppmann: cool, great sleuthing! Would you be interested in putting up a pull request for either variant you mentioned above? That looks very promising and warrants more investigation. Thanks!!

buck huppmann (JIRA)

unread,
Jan 12, 2016, 6:22:03 PM1/12/16
to puppe...@googlegroups.com
buck huppmann commented on Improvement PUP-5687

sorry, i'm not a coder, just a complainer

somebody with some aesthetic sense should actually
write the code and maybe figure out if there's
any other optimization to be done, as long as that
code is under scrutiny

(like, i have no idea what sort of heuristic should
be used to determine if it's worth constructing a
hash or if linear search through an Array is fast
enough)

Thomas Hallgren (JIRA)

unread,
Jan 13, 2016, 10:31:17 AM1/13/16
to puppe...@googlegroups.com

buck huppmann, what version of Puppet are you using?

Henrik Lindberg (JIRA)

unread,
May 16, 2017, 1:23:03 PM5/16/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
 
Change By: Henrik Lindberg
Labels: triaged
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
May 16, 2017, 1:23:05 PM5/16/17
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-5687
 
Re: resources type takes long time to evaluate

This is valuable if 4.x still does this. Worth investigating.

Henrik Lindberg (JIRA)

unread,
May 16, 2017, 1:24:03 PM5/16/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 5.y

Henrik Lindberg (JIRA)

unread,
May 16, 2017, 1:24:05 PM5/16/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Team: Agent

Henrik Lindberg (JIRA)

unread,
May 31, 2017, 12:45:04 PM5/31/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Sub-team: Language

Henrik Lindberg (JIRA)

unread,
May 31, 2017, 12:48:03 PM5/31/17
to puppe...@googlegroups.com
 
Re: resources type takes long time to evaluate

The same logic is in 4.x - nothing has changed.

Josh Cooper (JIRA)

unread,
Feb 27, 2019, 1:26:04 AM2/27/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Team: Server Coremunity
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Feb 27, 2019, 1:26:05 AM2/27/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sub-team: Language

Josh Cooper (JIRA)

unread,
Jun 19, 2019, 5:03:04 PM6/19/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: help_wanted

Josh Cooper (JIRA)

unread,
Jun 19, 2019, 5:17:04 PM6/19/19
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-5687
 
Re: resources type takes long time to evaluate

The user type has a similar problem when parsing an ssh authorized keys file:

      names.map { |keyname|
 
        Puppet::Type.type(:ssh_authorized_key).new(
 
          :name => keyname,
 
          :target => keyfile)
 
      }.reject { |res|
 
        catalog.resource_refs.include? res.ref
 
      }

In general Catalog#resource_refs should be avoided since it creates temporary strings for each resource in the catalog, compares res.ref against that, and throws away all of the data. It would be better to just check if the catalog contains the resource, something like catalog.contains_resource?(res), as that could be implemented as @resource_table.has_value?(ref).

Josh Cooper (JIRA)

unread,
Jun 19, 2019, 5:18:03 PM6/19/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: beginner help_wanted

Josh Cooper (Jira)

unread,
Oct 19, 2022, 11:25:01 PM10/19/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: Easy beginner help_wanted
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
May 17, 2023, 2:12:01 PM5/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-5773

Josh Cooper (Jira)

unread,
May 17, 2023, 2:12:01 PM5/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity Phoenix

Josh Cooper (Jira)

unread,
May 17, 2023, 2:12:03 PM5/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: Easy beginner help_wanted performance
Reply all
Reply to author
Forward
0 new messages