Jira (PUP-9815) `bundle exec rake syntax` reports invalid manifests as valid

unread,

Jul 6, 2019, 5:19:03 AM7/6/19

to puppe...@googlegroups.com

Alexander Fisher created an issue

Puppet Version: 6.5.0, 6.6.0

First reported on #puppet-dev slack by Christoph Maser.

Since puppet 6.5.0, `bundle exec rake syntax` doesn't work anymore.

$ export PUPPET_GEM_VERSION="6.4.2"

$ bundle update

...

Using puppet 6.4.2

...

$ bundle exec rake  validate

---> syntax:manifests

Could not parse for environment *root*: Syntax error at '' (file: themeier-systemd_cron/manifests/init.pp, line: 39, column: 11)   # < exit 1

$ unset PUPPET_GEM_VERSION

$ bundle update

...

Using puppet 6.6.0 (was 6.4.2)

...

$ bundle exec rake  validate

---> syntax:manifests

---> syntax:templates

---> syntax:hiera:yaml   < exit 0

I've used `git bisect` to identify the breaking change as

6103786d11955371fd6327b42a3ed933c146829c is the first bad commit

commit 6103786d11955371fd6327b42a3ed933c146829c

Author: Jesse Scott <je...@puppetlabs.com>

Date:   Wed Jun 13 17:34:37 2018 -0700

    (PUP-8984) Implement --render-as=json in `puppet parser validate`

    Tools like the Puppet Development Kit which invoke `puppet parser

    validate` on behalf of the user need a consistent, machine-readable

    output format so that they don't have to rely on complex and brittle

    regular expressions matching output that may change between Puppet

    releases.

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

unread,

Jul 6, 2019, 3:42:03 PM7/6/19

to puppe...@googlegroups.com

Alexander Fisher commented on

Probably best to fix in puppet-syntax. We're using a private api so we can't really expect it not to break from time to time.
https://github.com/voxpupuli/puppet-syntax/pull/106

unread,

Jul 7, 2019, 1:53:02 PM7/7/19

to puppe...@googlegroups.com

Alexander Fisher commented on

Reply all

Reply to author

Forward