Jira (PUP-9051) Refactor the SMF provider to implement enableable semantics

7 views
Skip to first unread message

Enis Inan (JIRA)

unread,
Aug 9, 2018, 6:55:02 PM8/9/18
to puppe...@googlegroups.com
Enis Inan created an issue
 
Puppet / Improvement PUP-9051
Refactor the SMF provider to implement enableable semantics
Issue Type: Improvement Improvement
Assignee: Enis Inan
Created: 2018/08/09 3:54 PM
Priority: Normal Normal
Reporter: Enis Inan

The SMF provider does not implement enableable semantics. For example, enabling a service also starts it, while disabling a service also stops it. That means if we do

enable  => true,
ensure => stop

The final state of the service is undefined – it will either be stopped (and disabled from starting up at boot) or running (and enabled to start at boot). We want it to be stopped, but enabled to start up again upon a reboot.

Work in this ticket consists of refactoring the SMF provider to properly implement enableable semantics so that we get rid of this confusing case.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Enis Inan (JIRA)

unread,
Aug 9, 2018, 6:57:02 PM8/9/18
to puppe...@googlegroups.com
Enis Inan commented on Improvement PUP-9051
 
Re: Refactor the SMF provider to implement enableable semantics

Will mark this ticket as in-progress after PUP-8957 gets merged up to master (since I need to cherry-pick my SMF refactor commit on top of it).

Enis Inan (JIRA)

unread,
Aug 14, 2018, 2:21:04 PM8/14/18
to puppe...@googlegroups.com
Enis Inan updated an issue
 
Change By: Enis Inan
Fix Version/s: PUP 6.0.0

Enis Inan (JIRA)

unread,
Sep 11, 2018, 6:00:14 PM9/11/18
to puppe...@googlegroups.com
Enis Inan updated an issue
The SMF provider does not implement enableable semantics. For example, enabling a service also starts it, while disabling a service also stops it. That means if we do
{code}
enable  => true,
ensure => stop
{code}

The final state of the service is undefined -- it will either be stopped (and disabled from starting up at boot) or running (and enabled to start at boot). We want it to be stopped, but enabled to start up again upon a reboot.


Work in this ticket consists of refactoring the SMF provider to properly implement enableable semantics so that we get rid of this confusing case.

 

UPDATE: This will likely be targeted for Puppet 7 since it is a breaking change, and we could not land it in time for the Puppet 6.0 release. Closed PR is here: [https://github.com/puppetlabs/puppet/pull/6993

Kenn Hussey (JIRA)

unread,
Sep 12, 2018, 9:19:02 AM9/12/18
to puppe...@googlegroups.com

Enis Inan (JIRA)

unread,
Sep 12, 2018, 1:07:04 PM9/12/18
to puppe...@googlegroups.com
Enis Inan updated an issue
Change By: Enis Inan
Fix Version/s: PUP 6.0.0
Fix Version/s: PUP 7.0.0

Geoff Nichols (JIRA)

unread,
Sep 13, 2018, 2:12:05 PM9/13/18
to puppe...@googlegroups.com

Geoff Nichols (JIRA)

unread,
Sep 13, 2018, 9:21:03 PM9/13/18
to puppe...@googlegroups.com
Geoff Nichols assigned an issue to Unassigned
Change By: Geoff Nichols
Assignee: Enis Inan

Geoff Nichols (JIRA)

unread,
Sep 13, 2018, 9:21:04 PM9/13/18
to puppe...@googlegroups.com

Geoff Nichols (JIRA)

unread,
Sep 13, 2018, 9:21:05 PM9/13/18
to puppe...@googlegroups.com
Geoff Nichols commented on Improvement PUP-9051
 
Re: Refactor the SMF provider to implement enableable semantics

Moved this to PUP 7 since we will not be landing this in time for the Puppet 6 release. We expect to be able to rebase and retarget https://github.com/puppetlabs/puppet/pull/6993.

Mihai Buzgau (Jira)

unread,
Oct 14, 2020, 3:38:02 AM10/14/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
 
Change By: Mihai Buzgau
Story Points: 3
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Mihai Buzgau (Jira)

unread,
Oct 14, 2020, 3:38:03 AM10/14/20
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Oct 19, 2020, 6:14:02 AM10/19/20
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
Nov 10, 2020, 5:37:04 AM11/10/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed platform-os
Reply all
Reply to author
Forward
0 new messages