Jira (PUP-10940) 'puppet facts diff' logs error when apt module is installed

Ciprian Badescu (Jira)

unread,

Feb 24, 2021, 9:32:02 AM2/24/21

to puppe...@googlegroups.com

Ciprian Badescu created an issue

Puppet /

PUP-10940

'puppet facts diff' logs error when apt module is installed

Issue Type:	Bug
Assignee:	Ciprian Badescu
Created:	2021/02/24 6:31 AM
Priority:	Normal
Reporter:	Ciprian Badescu

Platforms: OS X, Centos 7 (as tested by me), might be on all
pupptlabs-apt: 7.7.1(latest)

Step to reproduce:

install latest puppet 6
install puppetlabs-apt module
run `puppet facts diff`

❯ puppet --version

6.21.1

❯ puppet facts diff

{"hypervisors.vmware.version":{"new_value":"ESXi 6.7","old_value":""}}

❯ puppet module install puppetlabs-stdlib

Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...

Notice: Downloading from https://forgeapi.puppet.com ...

Notice: Installing -- do not interrupt ...

/etc/puppetlabs/code/environments/production/modules

└── puppetlabs-stdlib (v6.6.0)

❯ puppet facts diff

{"hypervisors.vmware.version":{"new_value":"ESXi 6.7","old_value":""}}

❯ puppet module install puppetlabs-apt

Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...

Notice: Downloading from https://forgeapi.puppet.com ...

Notice: Installing -- do not interrupt ...

/etc/puppetlabs/code/environments/production/modules

└─┬ puppetlabs-apt (v7.7.1)

  ├── puppetlabs-stdlib (v6.6.0)

  └── puppetlabs-translate (v2.2.0)

❯ puppet facts diff

E, [2021-02-17T07:14:34.049701 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_package_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

E, [2021-02-17T07:14:34.051667 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_package_dist_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

E, [2021-02-17T07:14:34.053433 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_package_security_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

E, [2021-02-17T07:14:34.055293 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_package_security_dist_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

E, [2021-02-17T07:14:34.057133 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

E, [2021-02-17T07:14:34.058807 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_dist_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

E, [2021-02-17T07:14:34.060489 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_security_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

E, [2021-02-17T07:14:34.062122 #1797] ERROR -- : Facter - Error while resolving custom fact fact='apt_security_dist_updates', resolution='<anonymous>': undefined method `[]' for nil:NilClass

{"hypervisors.vmware.version":{"new_value":"ESXi 6.7","old_value":""}}

/opt/puppetlabs/puppet/bin/facter-ng does not log any error so most likely it happens when resolving the facts added in puppet form modules.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Ciprian Badescu (Jira)

unread,

Feb 25, 2021, 2:35:01 AM2/25/21

to puppe...@googlegroups.com

Ciprian Badescu updated an issue

Puppet /

PUP-10940

'puppet facts diff' logs error when apt module is installed

Change By:	Ciprian Badescu
Story Points:	3 0

Add Comment

Ciprian Badescu (Jira)

unread,

Feb 25, 2021, 2:36:01 AM2/25/21

to puppe...@googlegroups.com

Ciprian Badescu updated an issue

Puppet /

PUP-10940

'puppet facts diff' logs error when apt module is installed

Change By:	Ciprian Badescu
Sprint:	NW - 2021-03-03

Add Comment

Ciprian Badescu (Jira)

unread,

Feb 26, 2021, 2:16:03 AM2/26/21

to puppe...@googlegroups.com

Ciprian Badescu updated an issue

Puppet /

PUP-10940

'puppet facts diff' logs error when apt module is installed

Change By:	Ciprian Badescu
Release Notes:	Bug Fix
Release Notes Summary:	Before this commit, `puppet facts diff` which is comparing facter 3 and facter 4 facts, didn't run facter 4 in a clean environment, leading to undefined behavior for custom facts resolving With this commit, puppet 4 facts are read running `puppet facts` in a new shell and the custom facts should be correctly resolved