Jira (FACT-1896) Facter spec has incorrect ruby dependency

2 views
Skip to first unread message

Alastair Young (JIRA)

unread,
Dec 7, 2018, 5:47:03 PM12/7/18
to puppe...@googlegroups.com
Alastair Young created an issue
 
Facter / Bug FACT-1896
Facter spec has incorrect ruby dependency
Issue Type: Bug Bug
Affects Versions: FACT 3.12.1
Assignee: Unassigned
Created: 2018/12/07 2:46 PM
Priority: Blocker Blocker
Reporter: Alastair Young

facter/lib/gemspec.in contains the following

s.required_ruby_version = '~> 2.1.7'

This is appearing in the puppet agent rpm along with ruby 2.4

We can't bundle our puppet manifest dependencies and roll out any new puppet modules using the newer gemspec format that seems to be triggering actually looking at this.

I believe the correct text should be

s.required_ruby_version = '>= 2.1.7'

manual editing of the deployed file gets around the issue in manual testing, but we can't do that in our real environment easily.

My ruby foo is not up to knowing if this is the "right" fix, or how to test for unforeseen consequences, but specifying ruby 2.1 in an install that ships with ruby 2.4 is intuitively wrong and bad in it's own right

 

 

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Scott McClellan (JIRA)

unread,
Dec 10, 2018, 2:13:03 PM12/10/18
to puppe...@googlegroups.com

Scott McClellan (JIRA)

unread,
Dec 10, 2018, 2:13:04 PM12/10/18
to puppe...@googlegroups.com
Scott McClellan updated an issue
Change By: Scott McClellan
Labels: packaging ruby

Morgan Rhodes (JIRA)

unread,
May 9, 2019, 6:53:04 PM5/9/19
to puppe...@googlegroups.com
Morgan Rhodes commented on Bug FACT-1896
 
Re: Facter spec has incorrect ruby dependency

Apologies for not finding this ticket sooner, but I believe https://tickets.puppetlabs.com/browse/FACT-1918 is a duplicate and the work from https://github.com/puppetlabs/facter/pull/1783 should resolve this.

Reply all
Reply to author
Forward
0 new messages