Jira (FACT-2965) Facter 4 outputs the processors.speed fact differently on AIX

[Luchian Nemes (Jira)]

Luchian Nemes created an issue

Facter / FACT-2965 Facter 4 outputs the processors.speed fact differently on AIX Issue Type: Bug Assignee: Unassigned Created: 2021/03/12 6:29 AM Priority: Normal Reporter: Luchian Nemes Running puppet facts diff on AIX 7.1 and AIX 7.2 gives the following output: { { "processors.speed": { "new_value": "3.42 GHz", "old_value": "3.43 GHz" } } Note: EXCLUDE_LIST from https://github.com/puppetlabs/puppet/blob/6.x/lib/puppet/face/facts.rb#L5 needs to be manually emptied to see above results. More info: https://docs.google.com/document/d/1QlX_mv17fZ4eVZa9zHxvTRVJ5sq88aj3GjUC6lVFiz0/edit#heading=h.gnnvlmulav1v Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Florin Dragos (Jira)]

Florin Dragos commented on FACT-2965

Re: Facter 4 outputs the processors.speed fact differently on AIX The difference here is a result of c++ rounding up, and ruby rounding the number down. The read value is 3425000000 (Hz) when converted to Ghz results in 3.425. When this gets rounded to 2 decimals, it ends up as 3.42 in ruby and 3.43 in c++. This only happens when the Ghz value has more than 2 decimals and ends with 5. As a fix we can round the number before formatting: https://github.com/puppetlabs/facter/blob/b9f6c32acb7433f05fe6227cc25d9d1c359b2f5b/lib/facter/util/facts/unit_converter.rb#L22 like  format('%<displayed_speed>.2f', displayed_speed: validated_speed.round(2)).to_s

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2965

Facter 4 outputs the processors.speed fact differently on AIX

Change By: Mihai Buzgau Sprint: NW - 2021-03-31

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2965 Facter 4 outputs the processors.speed fact differently on AIX

Change By: Mihai Buzgau Story Points: 1

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2965 Facter 4 outputs the processors.speed fact differently on AIX

Change By: Mihai Buzgau Team: Night's Watch

Add Comment

[Victor Bobosila (Jira)]

Victor Bobosila assigned an issue to Victor Bobosila

Facter / FACT-2965 Facter 4 outputs the processors.speed fact differently on AIX

Change By: Victor Bobosila Assignee: Victor Bobosila

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2965 Facter 4 outputs the processors.speed fact differently on AIX

Change By: Josh Cooper Fix Version/s: FACT 4.0.53

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Facter / FACT-2965 Facter 4 outputs the processors.speed fact differently on AIX

Change By: Claire Cadman Labels: doc_reviewed

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)