Jira (PUP-10253) Undeprecate source_permissions

29 views
Skip to first unread message

Julian (JIRA)

unread,
Jan 25, 2020, 3:57:03 PM1/25/20
to puppe...@googlegroups.com

Julian (JIRA)

unread,
Jan 25, 2020, 4:49:04 PM1/25/20
to puppe...@googlegroups.com

Jorie Tappa (JIRA)

unread,
Jan 27, 2020, 1:07:04 PM1/27/20
to puppe...@googlegroups.com
Jorie Tappa updated an issue
Change By: Jorie Tappa
Team: Coremunity

Jorie Tappa (JIRA)

unread,
Jan 27, 2020, 1:07:04 PM1/27/20
to puppe...@googlegroups.com
Jorie Tappa commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

Undeprecating this is possible.

t would be ideal if we could only use source_permissions for mode, not uid and gid, but this may not be possible.

Julian (JIRA)

unread,
Jan 27, 2020, 1:14:04 PM1/27/20
to puppe...@googlegroups.com
Julian commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

Jorie Tappa

It would be ideal if we could only use source_permissions for mode, not uid and gid, but this may not be possible.

{/quote}

why exactly is this ideal? this would break the feature of moving for example /home to an external storage location like /mnt/home where i want to copy all permissions, owners and groups exactly as they are in the moment.

Jorie Tappa (JIRA)

unread,
Jan 27, 2020, 1:53:04 PM1/27/20
to puppe...@googlegroups.com
Jorie Tappa commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

Julian in heterogenous environments where the gid and uid are not interchangeable, this makes things very complicated. For example, a file that is sourced from a *nix master/root user to a windows agent.

Dan33l (Jira)

unread,
Mar 5, 2020, 9:49:03 AM3/5/20
to puppe...@googlegroups.com
Dan33l commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

If an attribute (like owned by root) is not supported on the target, the type should fail by returning an error. It looks enough for me.

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Apr 24, 2020, 4:23:04 PM4/24/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Grooming

Josh Cooper (Jira)

unread,
Apr 24, 2020, 8:19:03 PM4/24/20
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

Bill Sirinek, Jim Richardson, Nate McCurdy, Raul Tambre, Maximilian Philipps since you commented on PUP-5921, I wanted to collect your feedback on this ticket.

I understand preserving file/directory modes is useful in some cases, especially for recursive directories, so I'm not against undeprecating it. But I have a harder time with uid/gid, especially when it's not 0. Assigning uid=502 across hosts is inviting a security problem. And then there are cross platforms concerns with Windows hosts.

For this ticket what if we added a new value for the source_permissions property, something like mode, which only applies the mode from the source, but we keep use and use_when_creating deprecated, and in puppet 7 we drop use and use_when_creating?

Julian Puppet is not really designed for the use case outlined in https://www.theurbanpenguin.com/puppet-moving-directories/. It may "work", but it's not going to scale for large numbers of files, it'll be slow, and you're better off using a bolt command for that.

Jim Richardson (Jira)

unread,
Apr 25, 2020, 8:03:04 AM4/25/20
to puppe...@googlegroups.com
Jim Richardson commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

I didn't see a option to comment on the JIRA ticket. I understand and agree with git/uid. I am pretty sure that rsync handles it with logic if the user/group names are on the targets it uses those regardless if the uid/git match, but they don't exist it falls back to original uid/gid. I realize puppet probably shouldn't get that close to the bare bones, I have no disagreement with your proposed solution as the only real use case in my scenario is that the mode be kept from the source files.

Sent from Mailspring (https://link.getmailspring.com/link/A8AFAF6E-1A50-49C7...@getmailspring.com/0?redirect=https%3A%2F%2Fgetmailspring.com%2F&recipient=aXNzdWUtdXBkYXRlcytKb3NoQ29vcGVyQHB1cHBldC5jb20%3D), the best free email app for work

Josh Cooper (Jira)

unread,
Jun 12, 2020, 9:04:02 PM6/12/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Grooming Hopper

Karl Pietri (Jira)

unread,
Nov 2, 2020, 5:54:03 PM11/2/20
to puppe...@googlegroups.com
Karl Pietri commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

Ever since the deprecation warning showed up I've been searching for a solution for the use case of a mixed directories of files/scripts put out by teams that don't have access to puppet code.  Its a common pattern and there just isn't a good solution without keeping this functionality.

Moving to something that only does the mode would be perfectly acceptable and probably better.

Josh Cooper (Jira)

unread,
Aug 3, 2021, 6:13:04 PM8/3/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper , Community PRs 2
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Steve Shipway (Jira)

unread,
Oct 13, 2022, 12:21:04 AM10/13/22
to puppe...@googlegroups.com
Steve Shipway commented on New Feature PUP-10253
 
Re: Undeprecate source_permissions

We use this attribute to automatically set up chroot environments, copying certain files from the OS.

It would be good to add an option  'source_permissions=>'use_mode_only' for when the file is being copied between systems.

 

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
Oct 19, 2022, 11:52:02 PM10/19/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity Phoenix

Josh Cooper (Jira)

unread,
Oct 20, 2022, 1:39:03 AM10/20/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: Easy
Reply all
Reply to author
Forward
0 new messages