Jira (PUP-9648) Drop PSON support

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2019/04/19 9:15 AM
Fix Versions:	PUP 7.0.0
Priority:	Normal
Reporter:	Josh Cooper

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the file resource's content => binary_file('/path/to/bin'). Now that rich data is supported and enabled by default, we should look into eliminating PSON support.

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Josh Cooper (JIRA)

unread,

Apr 19, 2019, 2:43:03 PM4/19/19

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Team:	Coremunity

Melissa Stone (Jira)

unread,

Apr 29, 2020, 5:22:03 PM4/29/20

to puppe...@googlegroups.com

Melissa Stone commented on

ping Nick Walker Charlie Sharpsteen is this something that users are relying on? It doesn't look like we have an actual deprecation warning for this yet.

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Nick Walker (Jira)

unread,

May 11, 2020, 2:53:04 PM5/11/20

to puppe...@googlegroups.com

Nick Walker commented on

Would this cause older versions of the agent to no longer be able to connect to platform 7 masters?

Josh Cooper (Jira)

unread,

Jul 21, 2020, 1:22:03 PM7/21/20

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Epic Link:	PUP- 9120 10593

Rob Braden (Jira)

unread,

Jul 22, 2020, 7:05:03 PM7/22/20

to puppe...@googlegroups.com

Rob Braden updated an issue

Puppet /

Change By:	Rob Braden
Labels:	platform_7

Maggie Dreyer (Jira)

unread,

Aug 10, 2020, 5:56:02 PM8/10/20

to puppe...@googlegroups.com

Maggie Dreyer updated an issue

Puppet /

Change By:	Maggie Dreyer

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support.

* Where does the fallback code live? Is it centralized or scattered around?
* There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

Maggie Dreyer (Jira)

unread,

Aug 10, 2020, 6:00:04 PM8/10/20

to puppe...@googlegroups.com

Maggie Dreyer commented on

I think we might need to make a call on how far back we want to support for agents if we do this. If we are going to say "all of them forever", then this ticket should be closed, because it's not possible to do.

Maggie Dreyer (Jira)

unread,

Aug 10, 2020, 6:03:03 PM8/10/20

to puppe...@googlegroups.com

Maggie Dreyer updated an issue

Puppet /

Change By:	Maggie Dreyer

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support.

* Where does the fallback code live? Is it centralized or scattered around?
* There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

* In what version did we add real rich data support that doesn't require PSON? That version is likely the oldest we can support if we do this.

Maggie Dreyer (Jira)

unread,

Aug 10, 2020, 6:06:02 PM8/10/20

to puppe...@googlegroups.com

Maggie Dreyer updated an issue

Puppet /

Change By:	Maggie Dreyer

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support.

* Where does the fallback code live? Is it centralized or scattered around?
* There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

* In what version did we add real rich data support that doesn't require PSON? That version is likely the oldest we can support if we do this. We think this happened in Puppet 6, which is likely too recent for this to be doable.

Maggie Dreyer (Jira)

unread,

Aug 10, 2020, 6:07:03 PM8/10/20

to puppe...@googlegroups.com

Maggie Dreyer updated an issue

Puppet /

Change By:	Maggie Dreyer

Puppet prefers JSON but will fallback to PSON if there are binary fact values or if the catalog contains binary content, such as the {{file}} resource's {{content => binary_file('/path/to/bin')}}. Now that rich data is supported and enabled by default, we should look into eliminating PSON support.

* Where does the fallback code live? Is it centralized or scattered around?
* There are some [mentions of PSON|https://github.com/puppetlabs/puppetserver/blob/master/src/clj/puppetlabs/services/ca/certificate_authority_core.clj#L163-L166] in the CA endpoint code. This is to support agents requesting certs in PSON. Can we drop this support?

* In what version did we add real rich data support that doesn't require PSON? That version is likely the oldest we can support if we do this. We think this happened in [ Puppet 6 |https://tickets.puppetlabs.com/browse/PUP-8587] , which is likely too recent for this to be doable.

Josh Cooper (Jira)

unread,

Aug 27, 2020, 11:53:03 AM8/27/20

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

Change By:	Josh Cooper
Epic Link:	PUP-10593

Josh Cooper (Jira)

unread,

Aug 27, 2020, 11:53:05 AM8/27/20

to puppe...@googlegroups.com

Josh Cooper commented on