Jira (PUP-10845) puppet apply creates warnings (since 7.x)

20 views
Skip to first unread message

Sebastian Krysmanski (Jira)

unread,
Dec 30, 2020, 9:54:04 AM12/30/20
to puppe...@googlegroups.com
Sebastian Krysmanski created an issue
 
Puppet / Bug PUP-10845
puppet apply creates warnings (since 7.x)
Issue Type: Bug Bug
Affects Versions: PUP 7.1.0
Assignee: Unassigned
Created: 2020/12/30 6:53 AM
Priority: Normal Normal
Reporter: Sebastian Krysmanski

Puppet Version: 7.1.0
Puppet Server Version: -
OS Name/Version: Windows 10 x64 20H2

Create a main.pp with the following contents (anywhere on your disk):

node default {
}

Run:

puppet apply main.pp

Desired Behavior:

No warnings should be shown.

Actual Behavior:

The following warnings are displayed:

C:/Program Files/Puppet Labs/Puppet/puppet/lib/ruby/vendor_ruby/puppet/pops/model/ast_transformer.rb:34: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
C:/Program Files/Puppet Labs/Puppet/puppet/lib/ruby/vendor_ruby/puppet/parser/ast/leaf.rb:29: warning: The called method `initialize' is defined here

If you guys need any additional information, I'd happy to provide them.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jan 4, 2021, 3:00:04 PM1/4/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10845
 
Re: puppet apply creates warnings (since 7.x)

We're shipping ruby 2.7.1 in puppet-agent 7, and interestingly the behavior is different in ruby 2.7.1 vs 2.7.2:

$ bx ruby --version && rspec spec/integration/parser/node_spec.rb
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin18]
Run options: exclude {:broken=>true, :benchmark=>true}
/Users/josh/work/puppet/lib/puppet/pops/model/ast_transformer.rb:34: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/josh/work/puppet/lib/puppet/parser/ast/leaf.rb:29: warning: The called method `initialize' is defined here
.................
 
Finished in 0.52381 seconds (files took 0.94527 seconds to load)
17 examples, 0 failures
 
$ rbenv shell 2.7.2
$ bx ruby --version && rspec spec/integration/parser/node_spec.rb
ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin18]
Run options: exclude {:broken=>true, :benchmark=>true}
.................

Josh Cooper (Jira)

unread,
Jan 4, 2021, 9:26:02 PM1/4/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Fix Version/s: PUP 7.2.0
Fix Version/s: PUP 6.20.0

Josh Cooper (Jira)

unread,
Jan 4, 2021, 9:26:05 PM1/4/21
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (Jira)

unread,
Jan 5, 2021, 6:55:04 PM1/5/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Josh Cooper (Jira)

unread,
Jan 6, 2021, 2:29:04 PM1/6/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity

Josh Cooper (Jira)

unread,
Jan 6, 2021, 3:01:04 PM1/6/21
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jan 11, 2021, 8:55:04 PM1/11/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-10845

Passed CI in fdeab5be29364dd7210327ef901eb7d39f7cde35

Josh Cooper (Jira)

unread,
Jan 11, 2021, 8:56:04 PM1/11/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes Summary: Eliminates ruby 2.7.x warnings when running "puppet apply" with node statements

Claire Cadman (Jira)

unread,
Jan 13, 2021, 9:06:04 AM1/13/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed
Reply all
Reply to author
Forward
0 new messages