Jira (PDB-1810) Filesync Service: Add new git sha1 field

2 views
Skip to first unread message

Kenneth Barber (JIRA)

unread,
Jul 17, 2015, 7:24:03 AM7/17/15
to puppe...@googlegroups.com
Kenneth Barber created an issue
 
PuppetDB / New Feature PDB-1810
Filesync Service: Add new git sha1 field
Issue Type: New Feature New Feature
Assignee: Unassigned
Created: 2015/07/17 4:23 AM
Fix Versions: PDB 3.1.0
Priority: Normal Normal
Reporter: Kenneth Barber

This ticket should cover (in theory) the entirety of the PDB-only requirements for providing the Filesync service solution. This depends on Puppet work to be done by one of the Puppet teams before this can commence.

My 'in my head' estimate is no more than 5 story points, but leaving story points blank so we can all discuss a proper estimate later on.

Overview

There is a largish project that requires a change to the PDB storage, for more information see here:

https://docs.google.com/a/puppetlabs.com/document/d/1HJSdlluYmNKfOOrFIvPAi79YQuVYSnq7XJGbfEqgi-U/edit

From a PuppetDB perspective the proposed change is basically to add a new field to the following object types during submission and query:

  • Catalogs
  • Reports

This field represents the sha1 hash of the internal VCS repository (probably git). The proposal is to simply include this in the wire format during command submission, and have it returnable (and queryable as a string) via the matching query endpoints.

Tasks

  • Create schema migrations to add the sha1 fields to each of the required tables
    probably just ‘reports’ and ‘catalogs’
    • not sure if its even worth normalizing this, I doubt it. Worth pondering later on.
    • Update the commands so that they can receive this new sha1 type and store it
  • Update the terminus to send this new data field
    • Obviously this field needs to be lifted from Puppet first from the report and catalog parts.
    • We need to be backward compatible here, in that we need to support old versions of Puppet that may not have this field (for reports at least, we may see a bump in the report version here for example).
    • As long as the Puppet interface isn’t surprising this should be very BAU.
  • Add query and view capabilities to all the main endpoints for this new field
    • Again, this should be a very BAU query engine change.
    • This should make export/import just ‘work’, although I think we need to bump the versioning when we do this in the export metadata.
  • Anonymization support
    • I highly doubt this is needed, but worth noting.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
Atlassian logo

Kylo Ginsberg (JIRA)

unread,
Jul 22, 2015, 4:01:11 PM7/22/15
to puppe...@googlegroups.com
Kylo Ginsberg commented on New Feature PDB-1810
 
Re: Filesync Service: Add new git sha1 field

Not sure if this comment changes anything in this ticket, but in conversations about Direct Puppet we've been discussing this field as an opaque string (which might happen to be a git sha, but that's a mere implementation detail).

/cc Josh Cooper

Kenneth Barber (JIRA)

unread,
Jul 23, 2015, 8:34:11 AM7/23/15
to puppe...@googlegroups.com
Kenneth Barber updated an issue
 
Change By: Kenneth Barber
This ticket should cover (in theory) the entirety of the PDB-only requirements for providing the Filesync service solution. This depends on Puppet work to be done by one of the Puppet teams before this can commence.

My 'in my head' estimate is no more than 5 story points, but leaving story points blank so we can all discuss a proper estimate later on.

h2. Overview

There is a largish project that requires a
 small  change to the PDB storage, for more information see here:


https://docs.google.com/a/puppetlabs.com/document/d/1HJSdlluYmNKfOOrFIvPAi79YQuVYSnq7XJGbfEqgi-U/edit

From a PuppetDB perspective the proposed change is basically to add a new field to the following object types during submission and query:

* Catalogs
* Reports


This field represents the sha1 hash of the internal VCS repository (probably git). The proposal is to simply include this in the wire format during command submission, and have it returnable (and queryable as a string) via the matching query endpoints.

h2. Tasks

* Create schema migrations to add the sha1 fields to each of the required tables

probably just ‘reports’ and ‘catalogs’
** not sure if its even worth normalizing this, I doubt it. Worth pondering later on.
** Update the commands so that they can receive this new sha1 type and store it
* Update the terminus to send this new data field
** Obviously this field needs to be lifted from Puppet first from the report and catalog parts.
** We need to be backward compatible here, in that we need to support old versions of Puppet that may not have this field (for reports at least, we may see a bump in the report version here for example).
** As long as the Puppet interface isn’t surprising this should be very BAU.
* Add query and view capabilities to all the main endpoints for this new field
** Again, this should be a very BAU query engine change.
** This should make export/import just ‘work’, although I think we need to bump the versioning when we do this in the export metadata.
* Anonymization support
** I highly doubt this is needed, but worth noting.

Steve Barlow (JIRA)

unread,
Jul 29, 2015, 11:29:13 AM7/29/15
to puppe...@googlegroups.com
Steve Barlow updated an issue
Change By: Steve Barlow
Sprint: PuppetDB 2015-08-12

Ryan Senior (JIRA)

unread,
Aug 24, 2015, 10:18:08 AM8/24/15
to puppe...@googlegroups.com
Ryan Senior updated an issue
Change By: Ryan Senior
Fix Version/s: PDB 3.1.0
Fix Version/s: PDB 3.2.0

Steve Barlow (JIRA)

unread,
Sep 10, 2015, 3:41:55 PM9/10/15
to puppe...@googlegroups.com
Steve Barlow updated an issue
Change By: Steve Barlow
Flagged: Impediment
This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)
Atlassian logo

Susan McNerney (JIRA)

unread,
Sep 17, 2015, 2:52:07 PM9/17/15
to puppe...@googlegroups.com
Susan McNerney updated an issue
Change By: Susan McNerney
Sprint: PuppetDB 2015-10-07

Ryan Senior (JIRA)

unread,
Sep 22, 2015, 9:52:04 AM9/22/15
to puppe...@googlegroups.com
Ryan Senior updated an issue
Change By: Ryan Senior
Story Points: 3

Ryan Senior (JIRA)

unread,
Sep 22, 2015, 12:34:06 PM9/22/15
to puppe...@googlegroups.com
Ryan Senior updated an issue
Change By: Ryan Senior
Story Points: 3 2

Wyatt Alt (JIRA)

unread,
Sep 22, 2015, 2:35:05 PM9/22/15
to puppe...@googlegroups.com
Wyatt Alt updated an issue
Change By: Wyatt Alt
Sprint: PuppetDB 2015- 10 09 - 07 23

Wyatt Alt (JIRA)

unread,
Sep 22, 2015, 2:35:06 PM9/22/15
to puppe...@googlegroups.com
Wyatt Alt assigned an issue to Wyatt Alt
Change By: Wyatt Alt
Assignee: Wyatt Alt

Kurt Wall (JIRA)

unread,
Sep 22, 2015, 5:45:03 PM9/22/15
to puppe...@googlegroups.com
Kurt Wall updated an issue
Change By: Kurt Wall
QA Risk Assessment: Low

Kurt Wall (JIRA)

unread,
Sep 22, 2015, 5:45:05 PM9/22/15
to puppe...@googlegroups.com
Kurt Wall updated an issue
Change By: Kurt Wall
QA Status: Reviewed

Kurt Wall (JIRA)

unread,
Sep 22, 2015, 5:46:29 PM9/22/15
to puppe...@googlegroups.com
Kurt Wall updated an issue
Change By: Kurt Wall
QA Risk Assessment Reason: New feature

Susan McNerney (JIRA)

unread,
Sep 23, 2015, 11:21:04 AM9/23/15
to puppe...@googlegroups.com
Susan McNerney updated an issue
Change By: Susan McNerney
Scope Change Category: Adopted
Scope Change Reason: Adopted from future sprint

Susan McNerney (JIRA)

unread,
Sep 23, 2015, 12:32:05 PM9/23/15
to puppe...@googlegroups.com
Susan McNerney updated an issue
Change By: Susan McNerney
Sprint: PuppetDB 2015-09-23 , PuppetDB 2015-10-07

Andrew Roetker (JIRA)

unread,
Sep 30, 2015, 1:26:04 PM9/30/15
to puppe...@googlegroups.com
Andrew Roetker assigned an issue to Andrew Roetker
Change By: Andrew Roetker
Assignee: Wyatt Alt Andrew Roetker

Susan McNerney (JIRA)

unread,
Oct 7, 2015, 12:39:04 PM10/7/15
to puppe...@googlegroups.com
Susan McNerney updated an issue
Change By: Susan McNerney
Sprint: PuppetDB 2015-09-23, PuppetDB 2015-10-07 , PuppetDB 2015-10-21

Kenneth Barber (JIRA)

unread,
Oct 21, 2015, 5:01:04 AM10/21/15
to puppe...@googlegroups.com
Kenneth Barber updated an issue
Change By: Kenneth Barber
Flagged: Impediment

Claudia Petty (Jira)

unread,
Jun 21, 2023, 10:56:03 AM6/21/23
to puppe...@googlegroups.com
Claudia Petty updated an issue
Change By: Claudia Petty
Labels: new-feature
This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages