Jira (PUP-11725) Enable strict mode by setting strict default to error

[Aria Li (Jira)]

Aria Li created an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error Issue Type: Task Assignee: Unassigned Created: 2023/01/24 4:51 PM Priority: Normal Reporter: Aria Li Puppet supports various strict language related settings. These were added in 2016 (puppet 4.x) and it's time to enable strict behavior by default. strict strict_variables Currently, strict defaults to warning and must default to error in order to enable strict mode by default. A good thing to verify - take a module like stdlib, test against puppet8 gem, change the setting for strict variables, and make sure the spec tests still pass. Note you can use the PUPPET_GEM_VERSION to pin to a local checkout of puppet rather than building a gem. Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Team: Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Josh Cooper Epic Link: PA-4664

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Josh Cooper Fix Version/s: PUP 8.0.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Josh Cooper Sprint: Phoenix 2023-02-15

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Sprint: Phoenix 2023-02- 15 01

Add Comment

[Aria Li (Jira)]

Aria Li assigned an issue to Aria Li

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Assignee: Aria Li

Add Comment

[Christopher Thorn (Jira)]

Christopher Thorn updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Christopher Thorn Sprint: Phoenix 2023-02-01 , Phoenix 2023-02-15

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li

Puppet supports various strict language related settings. These were added in 2016 (puppet 4.x) and it's time to enable strict behavior by default.

[strict|https://github.com/puppetlabs/puppet/blob/381a3e2b2e6858570fcc6e755bfae9eeff1226f1/lib/puppet/defaults.rb#L191] [strict_variables|https://github.com/puppetlabs/puppet/blob/381a3e2b2e6858570fcc6e755bfae9eeff1226f1/lib/puppet/defaults.rb#L2212]

Currently, strict defaults to warning and must default to error in order to enable strict mode by default.

A good thing to verify - take a module like stdlib, test against puppet8 gem, change the setting for strict variables , and make sure the spec tests still pass. Note you can use the PUPPET_GEM_VERSION to pin to a local checkout of puppet rather than building a gem.

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Release Notes Summary: The --strict setting was introduced in Puppet 4.x and can be set to off, warning, or error. For Puppet 8, strict mode will be on by default and --strict will be set to error. In strict mode, there will be extra validation & checkes will be performed and will fail as an error. This feature could potentially be a breaking change.

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Release Notes Summary: The --strict setting was introduced in Puppet 4.x and can be set to off, warning, or error. For Puppet 8, strict mode will be on by default and --strict will be set to error. Previously, --strict defaulted to warning. In strict mode, there will be extra validation & checkes checks will be performed and will fail as an error. This feature could potentially be a breaking change.

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Release Notes Summary: The -- strict setting was introduced in Puppet 4.x and can be set to off, warning, or error. For Puppet 8, strict mode will be on by default and -- which means strict will be set to error and strict_variables will be on . Previously, -- strict defaulted to warning. In With strict mode set to error , extra validation & checks will be performed and will fail as an error. This feature change could potentially be a breaking change.

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Release Notes Summary: The strict setting was introduced in Puppet 4.x and can be set to off, warning, or error. For Puppet 8, strict mode will be on by default which means strict will be set default to error and strict_variables will be on default to true . Previously, strict defaulted to warning. With strict set to error, extra validation & checks will be performed and will fail as an error. This change could potentially be a breaking change.

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Release Notes: New Feature

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Aria Li Release Notes: New Feature Enhancement

Add Comment

[Parker Leach (Jira)]

Parker Leach updated an issue

Puppet / PUP-11725 Enable strict mode by setting strict default to error

Change By: Parker Leach Labels: docs_reviewed

Add Comment