Jira (PUP-11764) Remove dependency on the test forge instance

Josh Cooper (Jira)

unread,

Feb 27, 2023, 1:01:04 PM2/27/23

to puppe...@googlegroups.com

Josh Cooper created an issue

Puppet /

PUP-11764

Remove dependency on the test forge instance

Issue Type:	Task
Assignee:	Unassigned
Created:	2023/02/27 10:00 AM
Priority:	Normal
Reporter:	Josh Cooper

Puppet currently relies on a test forge instance, but that is no longer supported. The following beaker tests rely on the test forge:

$ git grep stub_forge

acceptance/tests/environment/environment_scenario-bad.rb:  stub_forge_on(master)

acceptance/tests/modules/changes/invalid_module_install_path.rb:stub_forge_on(master)

acceptance/tests/modules/changes/missing_checksums_json.rb:stub_forge_on(master)

acceptance/tests/modules/changes/missing_metadata_json.rb:stub_forge_on(master)

acceptance/tests/modules/changes/module_with_modified_file.rb:stub_forge_on(master)

acceptance/tests/modules/changes/module_with_removed_file.rb:stub_forge_on(master)

acceptance/tests/modules/changes/unmodified_module.rb:stub_forge_on(master)

acceptance/tests/modules/list/with_environment.rb:stub_forge_on(master)

Convert these tests to rspec integration tests (see https://github.com/puppetlabs/puppet/blob/main/spec/integration/application/module_spec.rb) using the bacula test fixture instead of pmtacceptance-nginx.

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

Josh Cooper (Jira)

unread,

Feb 27, 2023, 1:05:01 PM2/27/23

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-11764

Remove dependency on the test forge instance

Change By:	Josh Cooper

Puppet currently relies on a test forge instance, but that is no longer supported. The following beaker tests rely on the test forge:

{noformat}

$ git grep stub_forge
acceptance/tests/environment/environment_scenario-bad.rb: stub_forge_on(master)
acceptance/tests/modules/changes/invalid_module_install_path.rb:stub_forge_on(master)
acceptance/tests/modules/changes/missing_checksums_json.rb:stub_forge_on(master)
acceptance/tests/modules/changes/missing_metadata_json.rb:stub_forge_on(master)
acceptance/tests/modules/changes/module_with_modified_file.rb:stub_forge_on(master)
acceptance/tests/modules/changes/module_with_removed_file.rb:stub_forge_on(master)
acceptance/tests/modules/changes/unmodified_module.rb:stub_forge_on(master)
acceptance/tests/modules/list/with_environment.rb:stub_forge_on(master)

{noformat}

Convert these tests to rspec integration tests (see https://github.com/puppetlabs/puppet/blob/main/spec/integration/application/module_spec.rb) using the bacula test fixture instead of pmtacceptance-nginx.

There should no longer be any usages of "stub_forge_on". Also remove any references to api-forge-aio02-petest.puppet.com