Jira (PUP-11649) Drop support for ruby < 2.7

34 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Oct 7, 2022, 12:14:02 PM10/7/22
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-11649
Drop support for ruby < 2.7
Issue Type: Task Task
Assignee: Unassigned
Created: 2022/10/07 9:13 AM
Priority: Normal Normal
Reporter: Josh Cooper
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
Oct 7, 2022, 12:14:03 PM10/7/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Update the gemspec to require ruby 2.7 or greater
Update the github actions to remove older ruby versions
Update branch protection rules

Morgan Rhodes (Jira)

unread,
Oct 11, 2022, 4:12:02 PM10/11/22
to puppe...@googlegroups.com
Morgan Rhodes commented on Task PUP-11649
 
Re: Drop support for ruby < 2.7

We need a puppet-agent branch so we have somewhere to land 8.x changes.

This is a good time to go in and clean up monkeypatches or ruby version checks.

Josh Cooper (Jira)

unread,
Oct 11, 2022, 4:33:03 PM10/11/22
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-11649

Check these call sites too: 

$ git grep RUBY_VERSION lib
lib/puppet.rb:if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new("2.5.0")
lib/puppet.rb:  raise LoadError, "Puppet #{Puppet.version} requires Ruby 2.5.0 or greater, found Ruby #{RUBY_VERSION.dup}."
lib/puppet.rb:Puppet::OLDEST_RECOMMENDED_RUBY_VERSION = '2.5.0'
lib/puppet.rb:  if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new(Puppet::OLDEST_RECOMMENDED_RUBY_VERSION)
lib/puppet.rb:    Puppet.deprecation_warning(_("Support for ruby version %{version} is deprecated and will be removed in a future release. See https://puppet.com/docs/puppet/latest/system_requirements.html for a list of supported ruby versions.") % { version: RUBY_VERSION })
lib/puppet/application.rb:      'ruby_version'   => RUBY_VERSION,
lib/puppet/defaults.rb:      :default => "Puppet/#{Puppet.version} Ruby/#{RUBY_VERSION}-p#{RUBY_PATCHLEVEL} (#{RUBY_PLATFORM})",
lib/puppet/util.rb:  if RUBY_VERSION >= "2.6"
lib/puppet/util/monkey_patches.rb:if RUBY_VERSION.to_f < 3.0

 

Morgan Rhodes (Jira)

unread,
Dec 1, 2022, 1:30:03 PM12/1/22
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
 
Change By: Morgan Rhodes
Sprint: Phoenix 2022-12-21

Morgan Rhodes (Jira)

unread,
Dec 1, 2022, 1:37:02 PM12/1/22
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Story Points: 3

Josh Cooper (Jira)

unread,
Dec 5, 2022, 8:36:02 PM12/5/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 8.0.0

Morgan Rhodes (Jira)

unread,
Dec 7, 2022, 1:33:02 PM12/7/22
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Sprint: Phoenix 2022-12-21

Tim Meusel (Jira)

unread,
Dec 12, 2022, 11:10:01 AM12/12/22
to puppe...@googlegroups.com
Tim Meusel commented on Task PUP-11649
 
Re: Drop support for ruby < 2.7

Hi!
I've a question. Why drop support for only Ruby 2.6 and older, and not even newer rubies? My understanding is that Puppet Agent packages will ship Ruby 3.2, so this could be used in the gemspec and for rubocop linting as well?

Michael Hashizume (Jira)

unread,
Dec 15, 2022, 1:18:03 PM12/15/22
to puppe...@googlegroups.com
Michael Hashizume updated an issue
 
Change By: Michael Hashizume
Sprint: Phoenix 2023-01-04

Tony Vu (Jira)

unread,
Dec 27, 2022, 12:06:01 PM12/27/22
to puppe...@googlegroups.com
Tony Vu assigned an issue to Christopher Thorn
Change By: Tony Vu
Assignee: Christopher Thorn

Morgan Rhodes (Jira)

unread,
Jan 4, 2023, 1:06:01 PM1/4/23
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Sprint: Phoenix 2023-01-04 , Phoenix 2023-01-18

Josh Cooper (Jira)

unread,
Jan 6, 2023, 10:57:02 PM1/6/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Update the gemspec to require ruby 2.7 or greater
Update ext/project_data.yaml to require ruby 2.7 or greater
Update
the github actions to remove older ruby versions
Update branch protection rules

Josh Cooper (Jira)

unread,
Jan 17, 2023, 12:33:03 PM1/17/23
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-11649
 
Re: Drop support for ruby < 2.7

Hi Tim Meusel yes, good question. I'd be ok requiring at least 3.1 or 3.2 in puppet8. Unfortunately, the process is a little complicated due to JRuby and not breaking other projects that use puppet as a library like bolt, module CI, etc. I'll file a separate ticket to bump the minimum after we have puppet/ruby 3.2 and puppetserver/jruby 9.4 builds in CI, but before we release Puppet 8.

Aria Li (Jira)

unread,
Apr 18, 2023, 6:27:01 PM4/18/23
to puppe...@googlegroups.com
Aria Li updated an issue
 
Change By: Aria Li
Release Notes Summary: Drops support for Ruby versions < 2.7

Aria Li (Jira)

unread,
Apr 18, 2023, 6:27:02 PM4/18/23
to puppe...@googlegroups.com
Aria Li updated an issue
Change By: Aria Li
Release Notes: Deprecation
Reply all
Reply to author
Forward
0 new messages