Jira (PUP-6185) Windows stat / lstat are inefficient - may calculate mode too frequently

[Ethan Brown (JIRA)]

Ethan Brown created an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently Issue Type: Bug Affects Versions: PUP 4.4.1 Assignee: Unassigned Created: 2016/04/18 9:57 PM Fix Versions: PUP 4.5.0 Labels: windows Priority: Normal Reporter: Ethan Brown Based on how stat and lstat are patched in Windows, there are a couple of problems: Monkey patches should probably execute code lazily, rather than optimistically (if possible) - i.e. don't calculate the lstat type until is actually asked for, then keep using the same value ((Windows::Security.get_mode}} is called every time the stats .mode is accessed - i.e. https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/file.rb#L261 To fix this, first capture the non-Windows behavior in tests. Find out if stat / lstat types are calculated immediately or not (as class methods, I would presume they're asked for then immediately thrown away). Similarly, ensure the behavior of the patched mode is consistent with other platforms. The goal is to ensure that our file system access patterns are inline with the semantics that these APIs normally impose. Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Steve Barlow Sprint: Windows 2016-05- 04 18

Add Comment

[Craig Gomes (JIRA)]

Craig Gomes commented on PUP-6185

Re: Windows stat / lstat are inefficient - may calculate mode too frequently Per backlog grooming, need more information. What is acceptance criteria? Current number of calls vs. expected number of calls. If part of 4.5 needs to be done by 5/9

Add Comment

[Craig Gomes (JIRA)]

Craig Gomes updated an issue

Puppet / PUP-6185

Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Craig Gomes Sprint: Windows 2016- 05 06 - 18 01

Add Comment

[Craig Gomes (JIRA)]

Craig Gomes updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Craig Gomes Fix Version/s: PUP 4.5.0 Fix Version/s: PUP 4.y

Add Comment

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Steve Barlow Sprint: Windows 2016-06- 01 15

Add Comment

[Craig Gomes (JIRA)]

Craig Gomes updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Craig Gomes Sprint: Windows 2016-06- 15 29

Add Comment

[Craig Gomes (JIRA)]

Craig Gomes updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Craig Gomes Sprint: Windows 2016- 06 008 - 29 10

Add Comment

[Kenaz Kwa (JIRA)]

Kenaz Kwa updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Kenaz Kwa Sprint: Windows 2016-08-10

Add Comment

[Kenaz Kwa (JIRA)]

Kenaz Kwa updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Kenaz Kwa Team: Agent & Platform Support

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Ethan Brown Fix Version/s: PUP 4.y Fix Version/s: PUP 5.y

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Sean McDonald (JIRA)]

Sean McDonald updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Sean McDonald Story Points: 2

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Ethan Brown Labels: tech_ windows

Add Comment

[Sean McDonald (JIRA)]

Sean McDonald updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Sean McDonald Labels: tech_ triaged  windows

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Ethan Brown Labels: tech-debt triaged windows

Add Comment

[Karen Van der Veer (JIRA)]

Karen Van der Veer updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Karen Van der Veer Sprint: Platform Core Grooming

Add Comment

[Karen Van der Veer (JIRA)]

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Josh Cooper Team: Platform Core Windows

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Josh Cooper Team: Windows Phoenix

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Josh Cooper Labels: performance tech-debt windows

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-6185 Windows stat / lstat are inefficient - may calculate mode too frequently

Change By: Josh Cooper Epic Link: PUP-5773

Add Comment