Jira (PUP-10041) Switch PMT to use puppet's http client

21 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Sep 24, 2019, 7:48:03 PM9/24/19
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Improvement PUP-10041
Switch PMT to use puppet's http client
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2019/09/24 4:47 PM
Priority: Normal Normal
Reporter: Josh Cooper

Switch the PMT to using puppet's HTTP client instead of creating its own Net::HTTP objects.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Nov 19, 2019, 5:39:03 PM11/19/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Switch the PMT to using puppet's HTTP client instead of creating its own Net::HTTP objects.


* Use system ssl context to make HTTP requests
* If there is a forge authorization header, it must be sent via {{Authorization: <token>}}
* Otherwise, if the {{Puppet[:module_repository]}} includes a username and password, eg. {{https://foo:b...@myforge.com}}, then the user and password should be passed to the {{Client#get(url, headers, user: 'foo', password: 'bar')}} method as keyword arguments.
* Supports compressed downloads. We should get this for free, but when using {{--http_debug}} make sure the {{Accept-Encoding}} header contains something like {{gzip;q=1.0,deflate;q=0.6,identity;q=0.3}}
* Continues to send {{User-Agent: PMT/1.1.1 (v3; Net::HTTP) Puppet/6.12.0 Ruby/2.5.7-p... etc}} header
* Continues to raise CommunicationsError and SSLVerifyErrors if exceptions occur
* Encodes URL path and query parameters the same way (eg when Puppet[:module_groups] is set, we use spaces instead of '+' in the query parameter.

Josh Cooper (JIRA)

unread,
Nov 19, 2019, 5:40:03 PM11/19/19
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Nov 19, 2019, 5:41:03 PM11/19/19
to puppe...@googlegroups.com
* Encodes URL path and query parameters the same way (eg when {{Puppet[:module_groups]}} is set, we use spaces instead of '+' in the query parameter. See also PUP-8008

Melissa Stone (JIRA)

unread,
Nov 19, 2019, 5:43:04 PM11/19/19
to puppe...@googlegroups.com
Melissa Stone updated an issue
Change By: Melissa Stone
Sprint: Coremunity Hopper

Josh Cooper (JIRA)

unread,
Nov 19, 2019, 6:55:03 PM11/19/19
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (JIRA)

unread,
Nov 19, 2019, 6:55:03 PM11/19/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper Platform Core KANBAN

Josh Cooper (JIRA)

unread,
Dec 5, 2019, 12:56:03 PM12/5/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 6.12.0

Josh Cooper (JIRA)

unread,
Dec 11, 2019, 11:12:03 PM12/11/19
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Dec 13, 2019, 12:11:04 PM12/13/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes Summary: The puppet module tool now uses puppet's http client to connect to the forge. The only user visible change should be that the "puppet module install" command will now observe the "Puppet[:sourceaddress]" setting. This is useful when running the install command on a puppetserver with multiple network interfaces and the puppet forge is only routable on some interfaces.
Release Notes: Bug Fix

Josh Cooper (JIRA)

unread,
Dec 13, 2019, 12:23:04 PM12/13/19
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-10041
 
Re: Switch PMT to use puppet's http client

Passed CI in f331cc7cc49111eaa41deacaf931bab72d8fa510

Kate Medred (JIRA)

unread,
Jan 13, 2020, 6:52:03 PM1/13/20
to puppe...@googlegroups.com
Kate Medred updated an issue
 
Change By: Kate Medred
Labels: resolved-issue-added
Reply all
Reply to author
Forward
0 new messages