Jira (FACT-3034) Use require_relative in facter

3 views
Skip to first unread message

Josh Cooper (Jira)

unread,
May 4, 2021, 2:40:04 PM5/4/21
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Facter / Improvement FACT-3034
Use require_relative in facter
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2021/05/04 11:39 AM
Priority: Normal Normal
Reporter: Josh Cooper

Update facter to use require_relative in cases where we know the file to load is in the same repo.

See PUP-11055 for JRuby complications

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Josh Cooper (Jira)

unread,
May 6, 2021, 6:45:04 PM5/6/21
to puppe...@googlegroups.com
Josh Cooper commented on Improvement FACT-3034
 
Re: Use require_relative in facter

The PR I created doesn't show any significant improvement on RedHat or Windows in terms of number of file syscalls or the time to run facter. For example, with and without my change, facter takes about 700ms on Windows 2019:

PS C:\Users\Administrator> Measure-Command { facter } | Select-Object TotalMilliseconds
 
TotalMilliseconds
-----------------
         698.9567

I'm going to close this as won't do. We can reopen later if need be.

Reply all
Reply to author
Forward
0 new messages