Jira (PUP-9395) provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

[Luca Zecca (JIRA)]

Luca Zecca created an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 Issue Type: Bug Affects Versions: PUP 5.5.2 Assignee: Unassigned Components: Types and Providers Created: 2019/01/03 8:06 AM Priority: Major Reporter: Luca Zecca Since version 3.x, gem will not have anymore the 2 params `-no-ri` and `-no-rdoc`, that currently are the default params.(https://github.com/puppetlabs/puppet/blob/24ead48f617cd3912491fe419ac7b67cda53a320/lib/puppet/provider/package/gem.rb#L131) when is used the provider gem in the type package. This should be addressed by adding an option to disable them or override them through the parameter `install_options` already existing in the type package. The version 3.x of rubygems is a constraint since the new bundler major version 2.0.0 dropped support for rubygem older than 3.0.0 : https://github.com/bundler/bundler/releases/tag/v2.0.0 .   Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Josh Cooper Since version 3.x, gem will not have anymore the 2 params ` {{\ - \ -no-ri ` }} and ` {{\ - \ -no-rdoc ` }} , that currently are the default params.([https://github.com/puppetlabs/puppet/blob/24ead48f617cd3912491fe419ac7b67cda53a320/lib/puppet/provider/package/gem.rb#L131)] when is used the provider gem in the type package. This should be addressed by adding an option to disable them or override them through the parameter `install_options` already existing in the type package. The version 3.x of rubygems is a constraint since the new bundler major version 2.0.0 dropped support for rubygem older than 3.0.0 : [https://github.com/bundler/bundler/releases/tag/v2.0.0] .

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 The alternative way to exclude documentation is to specify the --no-document option.

Add Comment

[Andreas Ntaflos (JIRA)]

Andreas Ntaflos commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

We ran into the same issue today, with Puppet 5.5.6 on Ubuntu 16.04 and 18.04: Error: Could not update: Execution of '/usr/bin/gem install -v 2.7.7 --no-rdoc --no-ri rubygems-update' returned 1: ERROR: While executing gem ... (OptionParser::InvalidOption) invalid option: --no-rdoc

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Branan Riley Team: Platform OS

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Branan Riley Labels: gem package sadness type_and_provider

Add Comment

[Branan Riley (JIRA)]

Branan Riley commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 It looks like --no-document has been around long enough that we should be able to just switch to it in all supported streams (5.5, 6.0, and master). I'll get this scheduled so it will go out in the upcoming set of releases.

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Branan Riley Sprint: Platform OS Kanban

Add Comment

[Thomas Kishel (JIRA)]

Thomas Kishel commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 Yes: https://github.com/puppetlabs/puppet/blob/099ab2efb8b1bd7649586a3a79312166dfb62e90/lib/puppet/provider/package/gem.rb#L135

Add Comment

[Rob Braden (JIRA)]

Rob Braden commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

We still need to address this, but fwiw bundler has dropped the rubygems 3.0.0 hard requirement: https://github.com/bundler/bundler/pull/6867

Add Comment

[Thomas Kishel (JIRA)]

Thomas Kishel commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

https://github.com/puppetlabs/puppet/pull/7320 targets 5.5.x

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols assigned an issue to Branan Riley

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Geoff Nichols Assignee: Branan Riley

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Geoff Nichols Story Points: 1

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Geoff Nichols Sprint: Platform OS Kanban , Skeletor Kanban

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Geoff Nichols Sprint: Platform OS Kanban, Skeletor Kanban , Skeletor Kanban

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Geoff Nichols Sprint: Platform OS Kanban, Skeletor Kanban, Skeletor Kanban , Skeletor Kanban

Add Comment

[Sebastian Miclea (JIRA)]

Sebastian Miclea updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Sebastian Miclea Fix Version/s: PUP 6.4.2

Add Comment

[Sebastian Miclea (JIRA)]

Sebastian Miclea updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Sebastian Miclea Fix Version/s: PUP 5.5.14

Add Comment

[Thomas Kishel (JIRA)]

Thomas Kishel commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 Done!

Add Comment

[Thomas Kishel (JIRA)]

Thomas Kishel updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Thomas Kishel Release Notes Summary: Puppet now uses the `--no-document` option instead of the deprecated `--no-rdoc --no-ri` options when installing gems, allowing compatibility with `rubygems` >= 3.0.0. [PUP-9395] Release Notes: Bug Fix

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Geoff Nichols Sprint: Platform OS Kanban, Skeletor Kanban, Skeletor Kanban, Skeletor Kanban , Skeletor Kanban

Add Comment

[Jean Bond (JIRA)]

Jean Bond commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 Branan Riley, is this fix also going into 6.0.9?

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Jean Bond Release Notes Summary:

Puppet now uses the `--no-document` option instead of the deprecated `--no-rdoc --no-ri` options when installing gems, allowing compatibility with `rubygems` >= 3.0.0. [PUP-9395]

documented for 6.4.2 and 5.5.14, waiting for confirmation on 6.0.9--jean

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Jean Bond Release Notes Summary: Puppet now uses the ` - - This release fixes an issue where you could no -document` option instead of longer specify multiple logging destinations on the deprecated command line with the `-- no-rdoc --no-ri logdest ` options option. This feature was temporarily broken when installing gems, allowing compatibility with we added the ability to specify a logging destination in ` rubygems puppet.conf ` >= 3 . 0.0. [PUP- 9395 9565 ] documented for 6 (https://tickets . 4 puppetlabs . 2 and 5.5.14, waiting for confirmation on 6.0.9 com/browse/PUP - -jean 9565)

Add Comment

[Thomas Kishel (JIRA)]

Thomas Kishel commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 Jean Bond The release notes I suggested have been replaced with the release notes for PUP-9565   ?

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Jean Bond Release Notes: Bug Fix Not Needed

Add Comment

[Jean Bond (JIRA)]

Jean Bond commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 Ah, I see, thank you Thomas Kishel! That helps; it was not clear whether this was even in Tuesday's release. Because the notes are covered in another ticket, I'll change the DOCS tab to reflect that.

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Jean Bond Comment: Ah, I see, thank you [~tom.kishel]! That helps; it was not clear whether this was even in Tuesday's release. Because the notes are covered in another ticket, I'll change the DOCS tab to reflect that.

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9395 provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Jean Bond Release Notes: Not Needed Bug Fix

Add Comment

[Jean Bond (JIRA)]

Jean Bond commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 Thomas Kishel, I'm sorry about that! When I learned that this was not going into Tuesday's release, I pasted in the drafted release note, but I grabbed the wrong one. I'll see if I can recover the correct one.

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Jean Bond Release Notes Summary: - This release fixes an issue where you could no longer specify multiple logging destinations on Puppet now uses the command line with the `-- logdest no-document ` option . This feature was temporarily broken to exclude documentation when we added installing gems, instead of the ability to specify a logging destination in deprecated ` puppet.conf --no-rdoc ` . [PUP and ` - 9565](https://tickets -no-ri` options . puppetlabs This change allows compatibility with `rubygems` 3 . com/browse/PUP-9565) 0 and greater.

Add Comment

[Thomas Kishel (JIRA)]

Thomas Kishel commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 No problem!

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Josh Cooper Fix Version/s: PUP 6.0.9

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 It appears this change was released in the recent z's: $ git show 5c578c99ed6ea414f1905e1d1cb934e0a4fa2bb2 commit 5c578c99ed6ea414f1905e1d1cb934e0a4fa2bb2 (5.5.x) Merge: 00dcdf2fdb cecb8ab91f Author: Sebastian Miclea <sebastia...@puppet.com> Date: Mon Apr 15 13:52:57 2019 +0300   Merge pull request #7320 from tkishel/PUP-9395_no_documentation_5   (PUP-9395) specify version-specific documentation params with install   $ git --no-pager tag --contains 5c578c99ed6ea414f1905e1d1cb934e0a4fa2bb2 5.5.14 6.0.9 6.4.2 Branan Riley can you confirm and resolve the ticket?

Add Comment

[Jean Bond (JIRA)]

Jean Bond updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Jean Bond Labels: gem package resolved-issue-added sadness type_and_provider

Add Comment

[Anton Fomenko (Jira)]

Anton Fomenko commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0 # puppetserver gem install --no-rdoc yaml WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/tmp/jruby-8145/jruby10086072876742673271jopenssl.jar) to field java.security.MessageDigest.provider WARNING: Please consider reporting this to the maintainers of org.jruby.ext.openssl.SecurityHelper WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release ERROR: While executing gem ... (OptionParser::InvalidOption) invalid option: --no-rdoc # puppetserver --version puppetserver version: 6.14.0 # puppetserver gem --version 3.0.6

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Anton Fomenko This ticket was due to puppet's gem providers passing deprecated/broken options to the gem command and was fixed awhile ago. The command puppetserver gem install --no-rdoc yaml needs to be changed to puppetserver gem install --no-document yaml.

Add Comment

[Anton Fomenko (Jira)]

Anton Fomenko commented on PUP-9395

Re: provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Josh Cooper, well yes, but that's an issue and I couldn't find any related bug/task in SERVER project.

Add Comment

[Anton Fomenko (Jira)]

[Anton Fomenko (Jira)]

Anton Fomenko updated an issue

Puppet / PUP-9395

provider gem in package type doesn't work anymore when rubygems is >= 3.0.0

Change By: Anton Fomenko Comment: [~josh], well yes, but that's an issue and I couldn't find any related bug/task in SERVER project.

Add Comment