Jira (PDB-3924) Avoid temp file flood during fact path gc

5 views
Skip to first unread message

Rob Browning (JIRA)

unread,
May 15, 2018, 12:32:03 PM5/15/18
to puppe...@googlegroups.com
Rob Browning created an issue
 
PuppetDB / Improvement PDB-3924
Avoid temp file flood during fact path gc
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2018/05/15 9:31 AM
Priority: Normal Normal
Reporter: Rob Browning
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Rob Browning (JIRA)

unread,
Jul 12, 2018, 6:46:03 PM7/12/18
to puppe...@googlegroups.com
Rob Browning assigned an issue to Rob Browning
Change By: Rob Browning
Assignee: Rob Browning

Rob Browning (JIRA)

unread,
Jul 25, 2018, 1:41:05 PM7/25/18
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 6.0.0

Rob Browning (JIRA)

unread,
Sep 7, 2018, 6:23:04 PM9/7/18
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 6.0.0
Fix Version/s: PDB 6.0.1

Rob Browning (JIRA)

unread,
Oct 12, 2018, 12:40:09 PM10/12/18
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 6.0.1

Charlie Sharpsteen (JIRA)

unread,
Nov 13, 2018, 11:14:02 AM11/13/18
to puppe...@googlegroups.com
Charlie Sharpsteen commented on Improvement PDB-3924
 
Re: Avoid temp file flood during fact path gc

We also observed this during an upgrade when migration 66 was being applied:

https://github.com/puppetlabs/puppetdb/blob/6.0.1/src/puppetlabs/puppetdb/scf/migrate.clj#L1472-L1481

Postgresql work_mem had to be temporarily boosted to 2 GB in order to get through the migration — otherwise the 4 hour service startup timeout was tripped and the upgrade failed. If there is a general solution to this problem, then migration 66 should be re-written to avoid tempfile generation.

Rob Browning (JIRA)

unread,
Jan 7, 2019, 1:33:03 PM1/7/19
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Release Notes Summary: PuppetDB should no longer cause PostgreSQL to create a inordinate number of temporary files during its periodic garbage collections.  Among other things, this could flood the PostgreSQL's log if its log_temp_files option was set to a small enough value.
Release Notes: Bug Fix

Rob Browning (JIRA)

unread,
Jan 7, 2019, 1:35:03 PM1/7/19
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 6.0.2
Fix Version/s: PDB 5.2.7

Rob Browning (JIRA)

unread,
Jan 7, 2019, 1:44:04 PM1/7/19
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 6.2.0

Rob Browning (JIRA)

unread,
Jan 7, 2019, 1:51:04 PM1/7/19
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 6.1.1

Kenn Hussey (JIRA)

unread,
Jan 8, 2019, 10:06:03 AM1/8/19
to puppe...@googlegroups.com
Kenn Hussey updated an issue
Change By: Kenn Hussey
Flagged: Impediment

Kenn Hussey (JIRA)

unread,
Jan 8, 2019, 3:57:06 PM1/8/19
to puppe...@googlegroups.com

Rob Browning (JIRA)

unread,
Jan 10, 2019, 4:40:04 PM1/10/19
to puppe...@googlegroups.com
Rob Browning commented on Improvement PDB-3924
 
Re: Avoid temp file flood during fact path gc

Kenn Hussey I'm not sure, but note that we currently use "Ready for Merge" as the criteria for the diffusing column on our Kanban board, and that column is where we keep track of things that have been committed to at least one branch, but haven't yet landed everywhere they're destined – in the typical case, they haven't been fully merged up (but there can be cases where we need to cherry-pick).

If there's some other state you'd prefer we use for that, then I assume we'd be happy to.

Thanks

Heston Hoffman (JIRA)

unread,
Jan 14, 2019, 7:19:06 PM1/14/19
to puppe...@googlegroups.com
Heston Hoffman updated an issue
 
Change By: Heston Hoffman
Labels: resolved-issue-added

Austin Blatt (JIRA)

unread,
Jan 17, 2019, 4:50:06 PM1/17/19
to puppe...@googlegroups.com
Austin Blatt updated an issue
Change By: Austin Blatt
Fix Version/s: PDB 6.1.1

Zachary Kent (Jira)

unread,
Mar 10, 2021, 3:33:02 PM3/10/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Sprint:
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Zachary Kent (Jira)

unread,
Mar 10, 2021, 3:34:06 PM3/10/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Sprint: Release Engineering Hopper

Morgan Rhodes (Jira)

unread,
Mar 11, 2021, 2:28:07 PM3/11/21
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Sprint: Release Engineering Hopper
Reply all
Reply to author
Forward
0 new messages