Jira (PUP-11543) templatewrapper.rb deprecation warnings on Ruby 3.1

1 view
Skip to first unread message

Josh Cooper (Jira)

unread,
May 24, 2022, 4:34:01 PM5/24/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Puppet / Bug PUP-11543
templatewrapper.rb deprecation warnings on Ruby 3.1
Change By: Josh Cooper
Summary: templatewrapper.rb deprecation warnings on Ruby 3.1
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo

Josh Cooper (Jira)

unread,
May 26, 2022, 12:03:02 AM5/26/22
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-11543
 
Re: templatewrapper.rb deprecation warnings on Ruby 3.1

ERB added the trim_mode keyword argument in ruby 2.6.0: https://github.com/ruby/ruby/commit/cc777d09f44fa909a336ba14f3aa802ffe16e010 If we drop 2.6 support, then we can switch to the keyword argument everywhere. Otherwise, we'll need to choose between positional and keyword args.

Josh Cooper (Jira)

unread,
Aug 8, 2022, 8:15:01 PM8/8/22
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-11543

There's a PR up for PUP-11552 so closing this. The PR should fix ERB warnings coming from templatewrapper and other places in the puppet repo.

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages