Jira (FACT-1888) 'os.release' values not correct for VZ7

23 views
Skip to first unread message

Kilian Engelhardt (JIRA)

unread,
Oct 4, 2018, 12:20:05 PM10/4/18
to puppe...@googlegroups.com
Kilian Engelhardt updated an issue
 
Facter / Bug FACT-1888
'os.release' values not correct for VZ7
Change By: Kilian Engelhardt
Affects Version/s: FACT 3.12.0
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Kilian Engelhardt (JIRA)

unread,
Oct 4, 2018, 12:20:05 PM10/4/18
to puppe...@googlegroups.com
Kilian Engelhardt created an issue
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2018/10/04 9:19 AM
Priority: Normal Normal
Reporter: Kilian Engelhardt

Facter 3.12.0 ships d9c30e5 which adds support for VirtuozzoLinux. This breaks parsing the release information. Instead, as a fallback, kernel version will be returned:
Version 3.12.0:

os => {
 
  architecture => "x86_64",
 
  family => "Linux",
 
  hardware => "x86_64",
 
  name => "VirtuozzoLinux",
 
  release => {
 
    full => "3.10.0-693.17.1.vz7.43.10",
 
    major => "3",
 
    minor => "10"
 
  },
 
  selinux => {
 
    enabled => false
 
  }
 
}

Version 3.11.4:

{
 
  architecture => "x86_64",
 
  family => "RedHat",
 
  hardware => "x86_64",
 
  name => "RedHat",
 
  release => {
 
    full => "7.5",
 
    major => "7",
 
    minor => "5"
 
  },
 
  selinux => {
 
    enabled => false
 
  }
 
}

In case of VirtuozzoLinux Facter should also return the correct release information. It's still in redhat-release:

# cat /etc/redhat-release 
Virtuozzo Linux release 7.5

Kenn Hussey (JIRA)

unread,
Oct 4, 2018, 3:36:06 PM10/4/18
to puppe...@googlegroups.com
Kenn Hussey commented on Bug FACT-1888
 
Re: 'os.release' values not correct for VZ7

Could this be a duplicate of FACT-1886?

Kilian Engelhardt (JIRA)

unread,
Oct 5, 2018, 6:48:10 AM10/5/18
to puppe...@googlegroups.com

Kenn Hussey No it's not. FACT-1886 is about adding support for Virtuozzo's PCS6.

The new support for Virtuozzo's VZ7 somehow breaks the former (facter 3.11.4) correct parsing of 'os.release' information.

So FACT-1886 is more or less depending on this issue (FACT-1888) being fixed, because support for PCS6 would break parsing it's 'os.release', too.

Scott McClellan (JIRA)

unread,
Oct 15, 2018, 2:19:05 PM10/15/18
to puppe...@googlegroups.com
Scott McClellan updated an issue
 
Change By: Scott McClellan
Labels: community help_wanted virtualization

Scott McClellan (JIRA)

unread,
Oct 15, 2018, 2:20:03 PM10/15/18
to puppe...@googlegroups.com
Scott McClellan updated an issue
Change By: Scott McClellan
Team: Platform OS

Geoff Nichols (JIRA)

unread,
Feb 19, 2019, 1:47:04 PM2/19/19
to puppe...@googlegroups.com
Geoff Nichols updated an issue
Change By: Geoff Nichols
Team: Platform OS Puppet Romania

Boris (JIRA)

unread,
Mar 6, 2019, 4:21:02 AM3/6/19
to puppe...@googlegroups.com
Boris commented on Bug FACT-1888
 
Re: 'os.release' values not correct for VZ7

We also stumbled across this issue. This issue results in other issues like:

  • pip3 gets the default package provider
  • templated repo files break because of os.release.major
  • monitoring that is depending on these entries wont work

This issue breaks our whole automated infrastructure so we rolled back  to puppet5 with facter version 3.11.7 (commit efb78024806a461a4b0c46819979085362790520)

Gheorghe Popescu (JIRA)

unread,
Mar 20, 2019, 8:07:01 AM3/20/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
 
Change By: Gheorghe Popescu
Sprint: PR - 2019-04-03

Mihai Buzgau (JIRA)

unread,
Apr 3, 2019, 5:38:07 AM4/3/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-04-03 , PR - 2019-04-17

Mihai Buzgau (JIRA)

unread,
Apr 17, 2019, 5:35:09 AM4/17/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-04-03, PR - 2019-04-17 , PR - 2019-05-02

Mihai Buzgau (JIRA)

unread,
May 2, 2019, 5:21:08 AM5/2/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-04-03, PR - 2019-04-17, PR - 2019-05-02 , PR - 2019-05-15

Mihai Buzgau (JIRA)

unread,
May 15, 2019, 5:29:08 AM5/15/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-04-03, PR - 2019-04-17, PR - 2019-05-02, PR - 2019-05-15 , PR - 2019-05-29

Boris (JIRA)

unread,
May 17, 2019, 3:45:02 AM5/17/19
to puppe...@googlegroups.com
Boris commented on Bug FACT-1888
 
Re: 'os.release' values not correct for VZ7

Hi,

will this get fixed someday? We really like to update our nodes to puppet6, because we really want to use the [Puppet Server: Intermediate CA|https://puppet.com/docs/puppetserver/6.3/intermediate_ca.html] and it looks like this is only supported for puppet6.

 

Cheers

 Boris

Mihai Buzgau (JIRA)

unread,
May 29, 2019, 5:22:07 AM5/29/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-04-03, PR - 2019-04-17, PR - 2019-05-02, PR - 2019-05-15, PR - 2019-05-29 , PR - 2019-06-12

Gheorghe Popescu (JIRA)

unread,
Jun 10, 2019, 9:51:04 AM6/10/19
to puppe...@googlegroups.com
Gheorghe Popescu commented on Bug FACT-1888
 
Re: 'os.release' values not correct for VZ7

Kilian Engelhardt let me know if e get this correctly. The fact that should be returned must be for example:

root@localhost bin]# ./facter os
 
{
 
  architecture => "x86_64",
 
  family => "Linux",
 
  hardware => "x86_64",
 
  name => "VirtuozzoLinux",
 
  release => {
 
    full => "7.6",
 
    major => "7",
 
    minor => "6"
 
  },
 
  selinux => {
 
    enabled => false
 
  }
 
}
 
[root@localhost bin]# cat /etc/redhat-release
 
Virtuozzo Linux release 7.6
 
[root@localhost bin]#

Boris (JIRA)

unread,
Jun 10, 2019, 9:54:03 AM6/10/19
to puppe...@googlegroups.com
Boris commented on Bug FACT-1888

Looks good. I would think that family should be rh and don’t miss package provider should be yum.

Gheorghe Popescu (JIRA)

unread,
Jun 10, 2019, 9:57:03 AM6/10/19
to puppe...@googlegroups.com

Ok, i'll look also into os family fact

Gheorghe Popescu (JIRA)

unread,
Jun 10, 2019, 10:25:02 AM6/10/19
to puppe...@googlegroups.com

Boris Kilian Engelhardt 

root@localhost bin]# ./facter --version
 
3.12.5 (commit c86b1bc6a91ca9614b5d18999d5f5056550ef120)
 
[root@localhost bin]# ./facter os
 
{
 
  architecture => "x86_64",
 
  family => "RedHat",
 
  hardware => "x86_64",
 
  name => "VirtuozzoLinux",
 
  release => {
 
    full => "7.6",
 
    major => "7",
 
    minor => "6"
 
  },
 
  selinux => {
 
    enabled => false
 
  }
 
}
 
[root@localhost bin]# cat /etc/redhat-release
 
Virtuozzo Linux release 7.6

I'll put a PR for this

Gheorghe Popescu (JIRA)

unread,
Jun 10, 2019, 10:32:03 AM6/10/19
to puppe...@googlegroups.com

Gheorghe Popescu (JIRA)

unread,
Jun 10, 2019, 10:34:04 AM6/10/19
to puppe...@googlegroups.com
Gheorghe Popescu assigned an issue to Gheorghe Popescu
 
Change By: Gheorghe Popescu
Assignee: Gheorghe Popescu

Mihai Buzgau (JIRA)

unread,
Jun 12, 2019, 4:21:07 AM6/12/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: PR - 2019-04-03, PR - 2019-04-17, PR - 2019-05-02, PR - 2019-05-15, PR - 2019-05-29, PR - 2019-06-12 , PR - 2019-06-25

Gheorghe Popescu (JIRA)

unread,
Jul 1, 2019, 3:10:04 AM7/1/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Fix Version/s: FACT 3.14.1

Mihai Buzgau (JIRA)

unread,
Jul 3, 2019, 8:31:03 AM7/3/19
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Fix Version/s: FACT 3.13.3
Fix Version/s: FACT 3.12.5
Fix Version/s: FACT 3.11.9

Gheorghe Popescu (JIRA)

unread,
Jul 3, 2019, 8:33:03 AM7/3/19
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Fix Version/s: FACT 3.11.9

Jean Bond (JIRA)

unread,
Jul 15, 2019, 5:26:02 PM7/15/19
to puppe...@googlegroups.com
Jean Bond updated an issue
Change By: Jean Bond
Labels: community help_wanted resolved-issue-added virtualization
Reply all
Reply to author
Forward
0 new messages