Jira (FACT-3177) Update facter acceptance tests to handle puppet7 vs puppet8

8 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jan 13, 2023, 12:00:04 AM1/13/23
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Facter / Task FACT-3177
Update facter acceptance tests to handle puppet7 vs puppet8
Issue Type: Task Task
Assignee: Unassigned
Created: 2023/01/12 8:59 PM
Priority: Normal Normal
Reporter: Josh Cooper

The ruby.rb acceptance test fails on ruby 3.2 because the test expects major version 2:

https://github.com/puppetlabs/facter/blob/c0ea419a816f289f1574fb39c50fb0ed55d4e330/acceptance/tests/facts/ruby.rb#L43

Changing the regex is easy, but the same test needs to run on both puppet7 and puppet8 streams.

We might be able to use the RELEASE_STREAM environment variable to select which ruby to expect, e.g. see the GH acceptance test does: https://github.com/puppetlabs/facter/blob/c0ea419a816f289f1574fb39c50fb0ed55d4e330/.github/actions/presuite.rb#L9

But when running acceptance tests manually from the CLI, the variable likely won't be set...

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
Jan 17, 2023, 12:00:02 AM1/17/23
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jan 17, 2023, 12:01:03 AM1/17/23
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jan 17, 2023, 1:09:01 PM1/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Phoenix 2023-01-18

Christopher Thorn (Jira)

unread,
Feb 3, 2023, 12:41:02 PM2/3/23
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages