Jira (PDB-5061) Empty password causes schema exception for migrator-password

Austin Blatt (Jira)

unread,

Mar 12, 2021, 2:53:03 PM3/12/21

to puppe...@googlegroups.com

Austin Blatt created an issue

PuppetDB /

PDB-5061

Empty password causes schema exception for migrator-password

Issue Type:	Bug
Assignee:	Unassigned
Created:	2021/03/12 11:52 AM
Priority:	Normal
Reporter:	Austin Blatt

clojure.lang.ExceptionInfo: Value does not match schema: {:migrator-password (not (instance? java.lang.String nil))}

        at schema.core$validator$fn__6137.invoke(core.clj:155)

        at schema.core$validate.invokeStatic(core.clj:164)

        at schema.core$validate.invoke(core.clj:159)

        at puppetlabs.puppetdb.config$configure_read_db.invokeStatic(config.clj:460)

        at puppetlabs.puppetdb.config$configure_read_db.invoke(config.clj:442)

        at puppetlabs.puppetdb.config$configure_dbs.invokeStatic(config.clj:467)

        at puppetlabs.puppetdb.config$configure_dbs.invoke(config.clj:462)

        at puppetlabs.puppetdb.config$convert_config.invokeStatic(config.clj:525)

        at puppetlabs.puppetdb.config$convert_config.invoke(config.clj:521)

        at puppetlabs.puppetdb.config$process_config_BANG_.invokeStatic(config.clj:683)

        at puppetlabs.puppetdb.config$process_config_BANG_.invoke(config.clj:679)

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Austin Blatt (Jira)

unread,

Mar 12, 2021, 3:07:02 PM3/12/21

to puppe...@googlegroups.com

Austin Blatt updated an issue

PuppetDB /

PDB-5061

Empty password causes schema exception for migrator-password

Change By:	Austin Blatt

{code}

clojure.lang.ExceptionInfo: Value does not match schema: {:migrator-password (not (instance? java.lang.String nil))}
        at schema.core$validator$fn__6137.invoke(core.clj:155)
        at schema.core$validate.invokeStatic(core.clj:164)
        at schema.core$validate.invoke(core.clj:159)
        at puppetlabs.puppetdb.config$configure_read_db.invokeStatic(config.clj:460)
        at puppetlabs.puppetdb.config$configure_read_db.invoke(config.clj:442)
        at puppetlabs.puppetdb.config$configure_dbs.invokeStatic(config.clj:467)
        at puppetlabs.puppetdb.config$configure_dbs.invoke(config.clj:462)
        at puppetlabs.puppetdb.config$convert_config.invokeStatic(config.clj:525)
        at puppetlabs.puppetdb.config$convert_config.invoke(config.clj:521)
        at puppetlabs.puppetdb.config$process_config_BANG_.invokeStatic(config.clj:683)
        at puppetlabs.puppetdb.config$process_config_BANG_.invoke(config.clj:679)

{code}

This is not broken in PE because of a convoluted set of issues. Firstly, we appear to only be using our schema validation on the read-database section and not the database section. Secondly PE always writes a {{read-database.ini}} file, which prevents the read database from getting defaulted to the database section which contains {{:migrator-password nil}}

Add Comment

Austin Blatt (Jira)

unread,

Mar 12, 2021, 3:12:02 PM3/12/21

to puppe...@googlegroups.com

In my debugging I was using {{cond->}} to prevent the defaulting to {{nil}}
{code}
(cond-> (contains? config :password) (update :migrator-password #(or % (:password config))))
{code}

Add Comment

Austin Blatt (Jira)

unread,

Mar 12, 2021, 3:14:02 PM3/12/21

to puppe...@googlegroups.com

Austin Blatt updated an issue

PuppetDB /

PDB-5061

Empty password causes schema exception for migrator-password

Change By:	Austin Blatt
Acceptance Criteria:	- When password is unset, migrator-password is not defaulted to nil - Schema validation happens on all database config sections, not just read-database - Config test that password-less database configs are valid
Release Notes:	Bug Fix

Add Comment

Austin Blatt (Jira)

unread,

Mar 12, 2021, 3:21:03 PM3/12/21

to puppe...@googlegroups.com

Austin Blatt updated an issue

PuppetDB /

PDB-5061

Empty password causes schema exception for migrator-password

Change By:	Austin Blatt

{code}
clojure.lang.ExceptionInfo: Value does not match schema: {:migrator-password (not (instance? java.lang.String nil))}
        at schema.core$validator$fn__6137.invoke(core.clj:155)
        at schema.core$validate.invokeStatic(core.clj:164)
        at schema.core$validate.invoke(core.clj:159)
        at puppetlabs.puppetdb.config$configure_read_db.invokeStatic(config.clj:460)
        at puppetlabs.puppetdb.config$configure_read_db.invoke(config.clj:442)
        at puppetlabs.puppetdb.config$configure_dbs.invokeStatic(config.clj:467)
        at puppetlabs.puppetdb.config$configure_dbs.invoke(config.clj:462)
        at puppetlabs.puppetdb.config$convert_config.invokeStatic(config.clj:525)
        at puppetlabs.puppetdb.config$convert_config.invoke(config.clj:521)
        at puppetlabs.puppetdb.config$process_config_BANG_.invokeStatic(config.clj:683)
        at puppetlabs.puppetdb.config$process_config_BANG_.invoke(config.clj:679)
{code}

This is not broken in PE because of a convoluted set of issues. Firstly, we appear to only be using our schema validation on the read-database section and not the database section. Secondly PE always writes a {{read-database.ini}} file, which prevents the read database from getting defaulted to the database section which contains {{:migrator-password nil}}

In my debugging I was using {{cond->}} to prevent the defaulting to {{nil}}
{code}

( -> config
(update :migrator-username #(or % (:user config)))
( cond-> (contains? config :password) (update :migrator-password #(or % (:password config)))) ))
{code}