Jira (FACT-3073) Inconsistencies to set Facter::Core::Execution.execute timeout

[Romain Tartière]

Romain Tartière created an issue

Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout Issue Type: Bug Assignee: Unassigned Components: Facter 4 Created: 2021/09/08 10:21 PM Priority: Normal Reporter: Romain Tartière The Facter::Core::Execution.execute method accept an option hash to control execution. The documentation tell to use "time_limit" to set a max duration for the command to complete, but the code actually use "limit" to set this. I happen that the previous version of Facter used "timeout" for this duration. Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Gabriel Nagy (Jira)]

Gabriel Nagy commented on FACT-3073

Re: Inconsistencies to set Facter::Core::Execution.execute timeout Merged to main in https://github.com/puppetlabs/facter/commit/2239630851761cb464fbb38cf75a8ee8f5b22ac3

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Facter / FACT-3073

Inconsistencies to set Facter::Core::Execution.execute timeout

Change By: Gabriel Nagy Release Notes: Bug Fix Release Notes Summary: Fix the mismatch of `Facter::Core::Execution.execute` arguments between Facter 3 and Facter 4. The `.execute` method now accepts a `timeout` option like Facter 3 does, and warns when unsupported options are passed in. (Fix contributed by community members https://github.com/smortex and https://github.com/johanfleury)

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout

Change By: Ciprian Badescu Story Points: 1

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout

Change By: Ciprian Badescu Team: Night's Watch

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout

Change By: Ciprian Badescu Sprint: NW - 2021-09-22

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes assigned an issue to Gabriel Nagy

Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout

Change By: Luchian Nemes Assignee: Gabriel Nagy

Add Comment

[Dorin Pleava (Jira)]

Dorin Pleava updated an issue

Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout

Change By: Dorin Pleava Fix Version/s: FACT 4.2.5

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Facter / FACT-3073 Inconsistencies to set Facter::Core::Execution.execute timeout

Change By: Claire Cadman Labels: doc-reviewed

Add Comment