Jira (PUP-7843) The list of reserved type names known to the parser validator is incomplete

[Thomas Hallgren (JIRA)]

Thomas Hallgren created an issue

Puppet / PUP-7843 The list of reserved type names known to the parser validator is incomplete Issue Type: Bug Assignee: Unassigned Created: 2017/08/15 1:01 AM Priority: Normal Reporter: Thomas Hallgren The Checker4_0 class, used for validating the AST produced by the puppet parser, keeps a list named RESERVED_TYPE_NAMES. This list is incomplete. It lacks the following entries: 'init' => true, 'object' => true, 'sensitive' => true, 'semver' => true, 'semverrange' => true, 'string' => true, 'timestamp' => true, 'timespan' => true, 'typeset' => true, Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7843 The list of reserved type names known to the parser validator is incomplete

Change By: Josh Cooper Fix Version/s: PUP 7.0.0

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7843

Re: The list of reserved type names known to the parser validator is incomplete Adding them to reserved type names means they cannot be used as defined types (and I assume other places?). So currently, puppet will allow string but not array: define string() {} string { 'mystring': }   define array() {} array { 'myarray': } And puppet only complains about the array: bx puppet parser validate reserved.pp Error: Could not parse for environment production: The name: 'array' is already defined by Puppet and can not be used as the name of a 'define' expression. (file: /Users/josh/work/puppet/reserved.pp, line: 4, column: 1) That said, what benefit is there to defining resource type names? Making this change could break manifests, and would need to be done on a major version boundary? Is there potential type confusion if we don't reserve these type names?

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7843

Re: The list of reserved type names known to the parser validator is incomplete

Targeting 7.0 but needs information for now

Add Comment

[Henrik Lindberg (Jira)]

Henrik Lindberg commented on PUP-7843

Re: The list of reserved type names known to the parser validator is incomplete

The issue is that for each define 'x' which is of type Resource['x'], there is also an alias 'X' to the defined Resource type. (the same for class 'x' which is a Class['x']). Thus any define or class in top scope has the potential to clash wrt. aliases vs. core data types.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7843

The list of reserved type names known to the parser validator is incomplete

Change By: Josh Cooper Epic Link: PUP-10591

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7843

Re: The list of reserved type names known to the parser validator is incomplete Merged to main in https://github.com/puppetlabs/puppet/commit/f8d955db000cadb21232801aa498d84fd1abd8a6

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7843

The list of reserved type names known to the parser validator is incomplete

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: A class or defined type in top scope can no longer be named 'init', 'object', 'sensitive', 'semver', 'semverrange', 'string', 'timestamp', 'timespan' or 'typeset' since those defined within core puppet. Those names can continue to be used in other scopes such as 'mymodule::object'.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7843

Re: The list of reserved type names known to the parser validator is incomplete This passed puppet CI in 89d9333618. PEZ failures are unrelated, so resolving

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-7843

The list of reserved type names known to the parser validator is incomplete

Change By: Claire Cadman Labels: doc_reviewed

Add Comment