Jira (PDB-4157) Review impact of connection limits in clj-http-client

Dylan Ratcliffe (JIRA)

unread,

Oct 15, 2018, 11:53:04 PM10/15/18

to puppe...@googlegroups.com

Dylan Ratcliffe created an issue

PuppetDB /

PDB-4157

Review impact of connection limits in clj-http-client

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2018/10/15 8:52 PM
Priority:	Major
Reporter:	Dylan Ratcliffe

All teams that use clj-http-client should review the impact of the changes described in PE-25106. The clj-http-client previously defaulted to a maximum of 2 connection per route (host & port combination) and was not configurable. This led to many performance bottlenecks and is likely the root cause of many unsolved issues at large customers. Any code that uses this library should:

Define a default that is appropriate for the use case
Expose the values in config
Make appropriate changes to the puppet_enterprise module to allow customers to make changes

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

Dylan Ratcliffe (JIRA)

unread,

Oct 23, 2018, 10:02:02 PM10/23/18

to puppe...@googlegroups.com

Dylan Ratcliffe updated an issue

PuppetDB /

PDB-4157

Review impact of connection limits in clj-http-client

Change By:	Dylan Ratcliffe
CS Priority:	Needs Priority

Add Comment

Adam Bottchen (JIRA)

unread,

Oct 25, 2018, 7:22:02 PM10/25/18

to puppe...@googlegroups.com

Adam Bottchen updated an issue

PuppetDB /

PDB-4157

Review impact of connection limits in clj-http-client

Change By:	Adam Bottchen
CS Priority:	Needs Priority Reviewed
CS Impact:	See for ORCH-2256 for review.

Add Comment

Rob Browning (JIRA)

unread,

Nov 2, 2018, 2:31:05 PM11/2/18

to puppe...@googlegroups.com

Rob Browning commented on

PDB-4157

Re: Review impact of connection limits in clj-http-client

It looks like we only use http-client in pdb in get-metric and submit-command-via-http, both of which I think are only used by tests, and the benchmark and fact-storage-benchmark subcommands. And it looks like we only use http-client for testing in pdbext.

So perhaps worth addressing, but it doesn't appear to affect pdb's normal operations right now.