Jira (FACT-3195) Inconsistency in disks serial number facts

22 views
Skip to first unread message

Romain Tartière

unread,
Apr 1, 2023, 2:04:02 PM4/1/23
to puppe...@googlegroups.com
Romain Tartière created an issue
 
Facter / Bug FACT-3195
Inconsistency in disks serial number facts
Issue Type: Bug Bug
Assignee: Unassigned
Components: Facter 4
Created: 2023/04/01 11:03 AM
Priority: Normal Normal
Reporter: Romain Tartière

On FreeBSD, starting with Facter 4.0.27, disks serial numbers are reported with the serial_number key.

On Linux, starting with Facter 4.2.6, disks serial numbers are reported with the serial key.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Romain Tartière

unread,
Apr 1, 2023, 2:08:02 PM4/1/23
to puppe...@googlegroups.com
Romain Tartière updated an issue
Change By: Romain Tartière
On FreeBSD, starting with Facter 4.0.27, disks serial numbers are reported with the _serial_number_ key :
{{
disks => {
  ada0 => {
    model => "Samsung SSD 850 PRO 512GB",
    serial_number => "S250NXAG959927J",
    size => "476
. 94 GiB",
    size_bytes => 512110190592
  }
}
os.family => FreeBSD}}

On Linux, starting with Facter 4.2.6, disks serial numbers are reported with the _serial_ key :

{{disks => {
  sda => {
    model => "INTEL SSDSC2BB48",
    serial => "BTWA617304H8480FGN",
    size => "447
. 13 GiB",
    size_bytes => 480103981056,
    type => "ssd",
    vendor => "ATA",
    wwn => "0x55cd2e404c21e895"
  },
  sdb => {
    model => "INTEL SSDSC2BB48",
    serial => "PHWA634503Q5480FGN",
    size => "447.13 GiB",
    size_bytes => 480103981056,
    type => "ssd",
    vendor => "ATA",
    wwn => "0x55cd2e414d4691b4"
  }
}
os.family => Debian}}

Romain Tartière

unread,
Apr 1, 2023, 2:09:01 PM4/1/23
to puppe...@googlegroups.com
Romain Tartière updated an issue
On FreeBSD, starting with Facter 4.0.27, disks serial numbers are reported with the _serial_number_ key:
{{
disks => {
  ada0 => {
    model => "Samsung SSD 850 PRO 512GB",
    serial_number => "S250NXAG959927J",
    size => "476.94 GiB",

    size_bytes => 512110190592
  }
}
os.family => FreeBSD
}}

On Linux, starting with Facter 4.2.6, disks serial numbers are reported with the _serial_ key:

{{ disks => {

  sda => {
    model => "INTEL SSDSC2BB48",
    serial => "BTWA617304H8480FGN",
    size => "447.13 GiB",
    size_bytes => 480103981056,
    type => "ssd",
    vendor => "ATA",
    wwn => "0x55cd2e404c21e895"
  },
  sdb => {
    model => "INTEL SSDSC2BB48",
    serial => "PHWA634503Q5480FGN",
    size => "447.13 GiB",
    size_bytes => 480103981056,
    type => "ssd",
    vendor => "ATA",
    wwn => "0x55cd2e414d4691b4"
  }
}
os.family => Debian
}}

Romain Tartière

unread,
Apr 1, 2023, 2:10:02 PM4/1/23
to puppe...@googlegroups.com
Romain Tartière commented on Bug FACT-3195
 
Re: Inconsistency in disks serial number facts

lib/schema/facter.yaml suggest the key should be 'serial_number'

Romain Tartière

unread,
Apr 1, 2023, 2:26:02 PM4/1/23
to puppe...@googlegroups.com

Also the wwn reported on Linux is not documented in lib/schema/facter.yaml.

What should we do here? Must we duplicate serial into serial_number on Linux for backwards compatibility?

Josh Cooper (Jira)

unread,
Apr 2, 2023, 8:57:01 PM4/2/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
On FreeBSD, starting with Facter 4.0.27, disks serial numbers are reported with the _serial_number_ key:

{code:json}
disks => {
  ada0 => {
    model => "Samsung SSD 850 PRO 512GB",
    serial_number => "S250NXAG959927J",
    size => "476.94 GiB",
    size_bytes => 512110190592
  }
}
os.family => FreeBSD
{code}

On Linux, starting with Facter 4.2.6, disks serial numbers are reported with the _serial_ key:

{code:json}
disks => {
  sda => {
    model => "INTEL SSDSC2BB48",
    serial => "BTWA617304H8480FGN",
    size => "447.13 GiB",
    size_bytes => 480103981056,
    type => "ssd",
    vendor => "ATA",
    wwn => "0x55cd2e404c21e895"
  },
  sdb => {
    model => "INTEL SSDSC2BB48",
    serial => "PHWA634503Q5480FGN",
    size => "447.13 GiB",
    size_bytes => 480103981056,
    type => "ssd",
    vendor => "ATA",
    wwn => "0x55cd2e414d4691b4"
  }
}
os.family => Debian
{code}

Josh Cooper (Jira)

unread,
Apr 2, 2023, 8:57:01 PM4/2/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: regression

Josh Cooper (Jira)

unread,
Apr 4, 2023, 4:20:02 PM4/4/23
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Apr 4, 2023, 4:21:02 PM4/4/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-11659

Josh Cooper (Jira)

unread,
Apr 23, 2023, 11:36:03 PM4/23/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP- 11659 11660
Reply all
Reply to author
Forward
0 new messages