Jira (PDB-5168) Log PQL parsing time whenever it's "too long"

Rob Browning (Jira)

unread,

Jun 30, 2021, 2:30:03 PM6/30/21

to puppe...@googlegroups.com

Rob Browning created an issue

PuppetDB /

PDB-5168

Log PQL parsing time whenever it's "too long"

Issue Type:	Improvement
Assignee:	Unassigned
Components:	PuppetDB
Created:	2021/06/30 11:29 AM
Priority:	Normal
Reporter:	Rob Browning

It appears that the PQL parser can go off the rails, and it might even be a known, more general issue: https://stackoverflow.com/questions/64165847/unbelievably-bad-parse-time

For now, so we can get a better impression of the scope of the problem, let's compute the PQL parse time and log it at warning level whenever it's greater than say 1 second. (Not sure about 1s, but we can determine the exact value before we merge.)

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

Austin Blatt (Jira)

unread,

Jun 30, 2021, 2:33:02 PM6/30/21

to puppe...@googlegroups.com

Austin Blatt commented on

PDB-5168

Re: Log PQL parsing time whenever it's "too long"

Here's an example of a pql query with 1,600 certnames that takes a long time to compile on the repl.

=> (require '[puppetlabs.puppetdb.pql :as pql] :reload-all)

=> (do (time (pql/parse-pql-query (str "nodes[] { certname in [\"" (clojure.string/join "\", \"" (repeat 1600 "heavy-empire.delivery.puppetlabs.net")) "\"] }" ))) nil)