Jira (PUP-10549) HTTP 406 Not Acceptable error message should contain format names

16 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jun 26, 2020, 12:55:03 PM6/26/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-10549
HTTP 406 Not Acceptable error message should contain format names
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/06/26 9:54 AM
Priority: Normal Normal
Reporter: Josh Cooper

If the server can't generate a response in a mime type that the agent accepts, the server will emit an HTTP 406 Not Acceptable error, but the message includes the format objects instead of the names, leading to an unintelligible message on the agent:

Warning: Error 406 on SERVER: Not Acceptable: No supported formats are acceptable (Accept: [#<Puppet::Network::Format:0x7854686e @required_methods=[:render_method, :intern_method], @thename=:json, @confine_collection=#<Puppet::ConfineCollection:0x5c6ddb08 @confines=[], @label="Puppet::Network::Format[json]">, @charset=#<Encoding:UTF-8>, @render_multiple_method="to_multiple_json", @extension="json", @intern_multiple_method="from_multiple_json", @render_method="to_json", @weight=15, @mime="application/json", @intern_method=:from_data_hash, @options=nil>, #<Puppet::Network::Format:0x1393113d @required_methods=[:render_method, :intern_method], @thename=:pson, @confine_collection=#<Puppet::ConfineCollection:0x31d503f1 @confines=[], @label="Puppet::Network::Format[pson]">, @charset=nil, @render_multiple_method="to_multiple_pson", @extension="pson", @intern_multiple_method="from_multiple_pson", @render_method="to_pson", @weight=10, @mime="text/pson", @intern_method=:from_data_hash, @options=nil>])

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 26, 2020, 2:41:03 PM6/26/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 6.17.0
Fix Version/s: PUP 5.5.21

Josh Cooper (Jira)

unread,
Jun 26, 2020, 2:41:03 PM6/26/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Bug Fix
Release Notes Summary: Print the names of the unacceptable network formats, not the format objects.

Josh Cooper (Jira)

unread,
Jun 26, 2020, 2:41:03 PM6/26/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 26, 2020, 2:43:04 PM6/26/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 29, 2020, 7:55:03 PM6/29/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 29, 2020, 7:56:03 PM6/29/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes Summary: Print the names of mime types from the unacceptable network formats, Accept header which are not acceptable to puppetserver instead of the format objects.

Josh Cooper (Jira)

unread,
Jun 30, 2020, 1:49:05 PM6/30/20
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
Jul 7, 2020, 6:22:03 AM7/7/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages