Jira (PUP-478) Implement Typed Facts

7 views
Skip to first unread message

Henrik Lindberg (JIRA)

unread,
Jan 15, 2015, 4:06:52 PM1/15/15
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
 
Puppet / Improvement PUP-478
Implement Typed Facts
Change By: Henrik Lindberg
Scrum Team: Language
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Feb 9, 2016, 11:09:03 PM2/9/16
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-478
 
Re: Implement Typed Facts

No it is not implemented as part of structured facts, that just makes fact have a data type other than String.
Reopening.

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Feb 9, 2016, 11:16:05 PM2/9/16
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Facts are currently  all strings. Consider converting  structured which makes  them  to Boolean and Numeric values (at  have different type. Their type is however not defined anywhere which means that different fat providers can return  a  minimum) at  different data type. In general, a node's facts defines  the  boundary (when they  majority of the input to compilation. Since their types  are  set as variables)  not defined it makes type inference impossible .

Consider having dual mode (accesses as top scope variables == string, accessed as fact[key] is typed.

Design
We should have  a mechanism  that allows facts  to  declare  be typed using  the  type of a fact in Facter  Puppet Type system .  (Using  We should assert that facts have  the  puppet  correct  type  system).

( There may be other issues related to  this ; typed facts)  should ideally be done by facter , but  decisions have to  can  be  made  done by the compiler) .

This issue relates to PP-477
 The type of each fact  ( strict numbers and the fact that it exists, should be available statically and declarative to enable validation as early as in parsing manifests ) .

Henrik Lindberg (JIRA)

unread,
Feb 9, 2016, 11:18:02 PM2/9/16
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Facts are currently structured which makes them have different type. Their type is however not defined anywhere which means that different fat providers can return a different data type. In general, a node's facts defines the majority of the input to compilation. Since their types are not defined it makes type inference impossible.

We should have a mechanism that allows facts to be typed using the Puppet Type system. We should assert that facts have the correct type (this should ideally be done by facter, but can be done by the compiler). The type of each fact (and the fact that it exists, should be available statically and declarative to enable validation as early as in parsing manifests).

Making facts typed would also help in delivering facts derived from ENV variables as it could deliver them as a better data type than a String.

Henrik Lindberg (JIRA)

unread,
Feb 9, 2016, 11:19:03 PM2/9/16
to puppe...@googlegroups.com
 
Re: Implement Typed Facts

Ping Kylo Ginsberg for facter in 5.0.0 perhaps ?

Henrik Lindberg (JIRA)

unread,
Sep 7, 2016, 6:12:18 PM9/7/16
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Team: Puppet Developer Support
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Ethan Brown (JIRA)

unread,
May 17, 2017, 5:34:02 PM5/17/17
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Team: Puppet Developer Experience Agent

Ethan Brown (JIRA)

unread,
May 17, 2017, 5:34:02 PM5/17/17
to puppe...@googlegroups.com
Ethan Brown commented on Improvement PUP-478
 
Re: Implement Typed Facts

Is this really something we think we might do Henrik Lindberg or should we just close?

Henrik Lindberg (JIRA)

unread,
May 18, 2017, 7:54:02 AM5/18/17
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-478
 
Re: Implement Typed Facts

I would really like facts to be type - as it is now you have no idea what the data type of something is. At some point we want to have rich type support in facts as well - then they need to be serialized.

Moses Mendoza (JIRA)

unread,
May 18, 2017, 1:55:28 PM5/18/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Labels: triaged

Josh Cooper (JIRA)

unread,
Mar 12, 2018, 11:49:03 PM3/12/18
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-478
 
Re: Implement Typed Facts

We've seen real world examples where ec2 metadata is a binary gzip and other cases where ec2 metadata is sensitive. Having typed data would be useful.

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Maggie Dreyer (JIRA)

unread,
Oct 29, 2018, 7:20:02 PM10/29/18
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
Change By: Maggie Dreyer
Team: Server Coremunity

Josh Cooper (Jira)

unread,
May 17, 2023, 2:14:01 PM5/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Component/s: Language
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
May 17, 2023, 2:14:02 PM5/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity

Josh Cooper (Jira)

unread,
May 17, 2023, 2:14:03 PM5/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-5854

Josh Cooper (Jira)

unread,
May 17, 2023, 2:14:03 PM5/17/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: validation
Reply all
Reply to author
Forward
0 new messages